#630 Add style keys #634
Merged
#630 Add style keys #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kept legacy names in case anyone is using them currently. I just tested in the demo app, comparing against an unchanged version. |
|
Resolves #630 |
|
Some tests are failed |
See this comment |
DevFromDownUnder
force-pushed
the
develop
branch
from
fb421b0
to
6b6c99f
Compare
|
Reset and branched that extra commit, should be good now |
|
There must be a bug in VS, that last commit was pushed to a branch, it should not have been picked up here |
DevFromDownUnder
force-pushed
the
develop
branch
from
ce150be
to
6b6c99f
Compare
Fixed, can you merge/close this one off if you have completed it |
enisn
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add keys to styles
Standardise style key names
Add an example of an override dictionary entry