Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a parser for data from DDR4 SPD EEPROM. It uses
tXX_L
timings as we do not supporttXX_S
yet. It also checks page size to determine minimaltFAW
in clocks.I've tested this on ZCU104 with MTA4ATF51264HZ and the timings taken from SPD are correct (I also verified SPD data with reference on Micron's website), but when I was using the timings taken from SPD the module failed during leveling.
I checked that this is not due to the generation process, because changing the timings in the module definition gave the same results. I found that the only timings that differed enough to result in different
timing_settings
weretFAW
(5 -> 7) andtCCD
(1 -> 2). I wonder why this would result in leveling failing, when the timings increased, not decreased. Could this somehow influence leveling process?I added SPD parsing tests in
test_modules.py
but one is being skipped for now. Maybe we can merge this and I can create an issue with information about this problem?