Skip to content
This repository has been archived by the owner on Jun 9, 2018. It is now read-only.

What's new in v2.x #23

Closed
MartijnR opened this issue Jan 7, 2014 · 10 comments
Closed

What's new in v2.x #23

MartijnR opened this issue Jan 7, 2014 · 10 comments

Comments

@MartijnR
Copy link
Member

MartijnR commented Jan 7, 2014

  • check current look here: http://dristhi-dev.enketo.org/ on a mobile device (if issue with fonts in browser, use different browser)
  • repo: MartijnR/enketo-dristhi (everything else is added to this repo as git submodules)
    this time you'll have to clone the repo (make sure to also update the submodules and their submodules and their ... etc...) and include them in your require.js build system
  • change: require.js used throughout (and everything is modular behind the scenes now, which is great if you want to improve enketo-core.... )
  • change: enabling/disabling widget now just means adding/removing a line in config.json
  • change: bootstrap3 upgrade
  • change: many styling fixes
  • change: new widgets (likert, horizontal choices)
  • change: performance should be improved in particular for notes, labels that include media, etc.

I expect you'll want to change the structure of this repo to make it as easy as possible for you to keep Dristhi up to date (and lots of exciting stuff is coming!). Go crazy (!), as long as I can still run the template.html file inside a browser for Enketo development and troubleshooting.

@kirang20
Copy link
Contributor

kirang20 commented Jan 8, 2014

Thanks for the information Martijn. Since you have introduced RequireJS on Enketo we will have to add that to Ziggy also (a long pending task)!
We will keep you posted.

@MartijnR
Copy link
Member Author

MartijnR commented Jan 8, 2014

Cool, and thanks for pushing me towards RequireJS. I love it!

On Tue, Jan 7, 2014 at 9:54 PM, Kiran G notifications@github.com wrote:

Thanks for the information Martijn. Since you have introduced RequireJS on
Enketo we will have to add that to Ziggy also (a long pending task)!
We will keep you posted.


Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-31805889
.

Did you know that Enketo Smart Paper has now become the #1 tool for data
collection? Don't fall behind. Use it!

Enketo https://enketo.org |
LinkedInhttp://www.linkedin.com/company/enketo-llc |
GitHub https://github.com/MartijnR

@kirang20
Copy link
Contributor

Hi @MartijnR,

Some updates about the upgrade (actually the attempt to upgrade):

  • We have changed Ziggy to use RequireJS module definitions
  • Integrated Ziggy to enketo-dristhi repo (added as a git submodule in lib directory, changed the root main.js to include ziggy modules instead of the mocks)

There are two major issues we are facing for now on Dristhi app and also on Samsung Tab 3 Internet app:

I am still debugging the first issue but have not identified any cause for it yet. It will be really helpful if you can help us with this one as we are stuck due to this.

Thanks,
Dristhi Devs

@MartijnR
Copy link
Member Author

ah... well problems were to be expected... just too bad, I have to dust off the old Tab2...

Will also look at style.

On Thu, Jan 16, 2014 at 11:52 PM, Kiran G notifications@github.com wrote:

Hi @MartijnR https://github.com/MartijnR,

Some updates about the upgrade (actually the attempt to upgrade):

  • We have changed Ziggy to use RequireJS module definitions
  • Integrated Ziggy to enketo-dristhi repo (added as a git submodule in
    lib directory, changed the root main.js to include ziggy modules instead of
    the mocks)

There are two major issues we are facing for now on Dristhi app and also
on Samsung Tab 3 Internet app:

I am still debugging the first issue but have not identified any cause for
it yet. It will be really helpful if you can help us with this one as we
are stuck due to this.

Thanks,
Dristhi Devs


Reply to this email directly or view it on GitHubhttps://github.com//issues/23#issuecomment-32583846
.

Did you know that Enketo Smart Paper has now become the #1 tool for data
collection? Don't fall behind. Use it!

Enketo https://enketo.org |
LinkedInhttp://www.linkedin.com/company/enketo-llc |
GitHub https://github.com/MartijnR

@MartijnR
Copy link
Member Author

#24

@MartijnR
Copy link
Member Author

#25

@MartijnR
Copy link
Member Author

@kirang20 no new issues today? So quiet... :)

@kirang20
Copy link
Contributor

I was on leave yesterday so could not test :P.
But I was able to save a form today, so it looks like all issues have been resolved :).
We still need to work on the styles, so I will send out an APK and people can give feedback.
We are working on restructuring the repo so that with the same requirejs config and template.html we can run the forms on both browser and tablet (I also have a few questions which I will try to find answers for). Expect a pull request on Monday.
Thanks a lot for all the help.

@kirang20
Copy link
Contributor

We have sent a pull request with the below changes:

  • Added Ziggy as submodule
  • Changed some module definitions such that the forms work both on Browser (with mock objects) and on Dristhi app (using Android objects)

We were not sure if there are any tests that we need to run/fix, so if something is broken then please tell us, we will fix it.
Also, we did not want to duplicate code to create a separate build for Dristhi app, so we are including mocks in dristhi build also, but they will not be used. While this solved the duplication problem there is one small issue with this. The combined and minified file size with mocks and Ziggy is more than 1MB, primarily because of transforms.mock.js. So if you have better ideas on how to not duplicate the code but still not have the mocks in the combined js file then we can use that.

Thanks for helping us during the upgrade.
Dristhi Devs

@MartijnR
Copy link
Member Author

Cool. Thanks!

The tests are just just for style stuff (the real tests are in MartijnR/enketo-json). Atm, the Travis build fails to get the ziggy submodule. Probably a minor thing.

Initial thought about transforms.mock.js is to lazily load this (if !window.androidContext) in which case it wouldn't be in the build output, and you could omit it from the dristhi app itself.

I'll have a look!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants