Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcuts don't use the query params #328

Closed
poi33 opened this issue Sep 26, 2023 · 1 comment · Fixed by #586
Closed

Shortcuts don't use the query params #328

poi33 opened this issue Sep 26, 2023 · 1 comment · Fixed by #586
Assignees
@pmi
Labels
bug Something isn't working

Comments

@poi33
Copy link
Contributor

poi33 commented Sep 26, 2023

Its possible to add paramters to the shortcut.
Currently they are ignored by the shortcut implementation
image
@poi33 poi33 added the bug Something isn't working label Sep 26, 2023
@pmi pmi self-assigned this May 7, 2024
pmi added a commit that referenced this issue May 7, 2024
@pmi
Shortcuts don't use the query params #328
47037c1
@pmi pmi linked a pull request May 7, 2024 that will close this issue
Shortcuts don't use the query params #328 #586
Merged
pmi added a commit that referenced this issue May 7, 2024
@pmi
Shortcuts don't use the query params #328
9cf7b58
pmi added a commit that referenced this issue May 10, 2024
@pmi
Shortcuts don't use the query params #328
d1fa931 
- add test
@pmi pmi closed this as completed in #586 May 13, 2024
pmi added a commit that referenced this issue May 13, 2024
@pmi
Shortcuts don't use the query params #328
4335fbb
pmi added a commit that referenced this issue May 13, 2024
@pmi
Shortcuts don't use the query params #328
a8444e7 
- add test
@mortyeriksen
Copy link
Member

Works!

Test url: https://www.enonic-qa.com/resources/enonic-xp-all-you-need-to-know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmi pmi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shortcuts don't use the query params #328 enonic/npm-nextjs-adapter
3 participants
@mortyeriksen @pmi @poi33