Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create session for login url #10460 #10495

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

rymsha
Copy link
Contributor

@rymsha rymsha commented Apr 2, 2024

No description provided.

@rymsha rymsha linked an issue Apr 2, 2024 that may be closed by this pull request
@rymsha rymsha force-pushed the 10460-do-not-create-session-for-login-url branch 2 times, most recently from 75be426 to 54653e4 Compare April 4, 2024 11:36
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 83.14607% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 84.53%. Comparing base (55fed48) to head (e2b88f1).
Report is 9 commits behind head on master.

Files Patch % Lines
...nic/xp/core/impl/security/SecurityInitializer.java 81.88% 8 Missing and 15 partials ⚠️
...nic/xp/core/impl/security/SecurityServiceImpl.java 20.00% 4 Missing ⚠️
...enonic/xp/portal/impl/RedirectChecksumService.java 90.90% 2 Missing ⚠️
.../portal/impl/handler/identity/IdentityHandler.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10495      +/-   ##
============================================
+ Coverage     84.51%   84.53%   +0.02%     
- Complexity    19638    19656      +18     
============================================
  Files          2608     2609       +1     
  Lines         68184    68164      -20     
  Branches       5443     5450       +7     
============================================
- Hits          57626    57625       -1     
+ Misses         7927     7896      -31     
- Partials       2631     2643      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rymsha rymsha force-pushed the 10460-do-not-create-session-for-login-url branch from 54653e4 to a710cb8 Compare April 4, 2024 13:44
@rymsha rymsha marked this pull request as ready for review April 4, 2024 14:04
@rymsha rymsha force-pushed the 10460-do-not-create-session-for-login-url branch from a710cb8 to f943f42 Compare April 4, 2024 15:32
@rymsha rymsha force-pushed the 10460-do-not-create-session-for-login-url branch from f943f42 to e2b88f1 Compare April 4, 2024 15:43
@rymsha rymsha merged commit 64ab74b into master Apr 5, 2024
8 of 9 checks passed
@rymsha rymsha deleted the 10460-do-not-create-session-for-login-url branch April 5, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not create session for login url
3 participants