XML Format #88
Merged
XML Format #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 4, 2020 12:54
RonRahaman
commented
Mar 6, 2020
| </neutronics> | ||
| <heat_fluids> | ||
| <driver>surrogate</driver> | ||
| <pressure_bc>101325.0</pressure_bc> |
There was a problem hiding this comment.
This value of <pressure_bc> is the outlet temperature used in tests/unit/test_surrogate_th.cpp. Rather than being set in test driver, I'm setting it here.
RonRahaman
commented
Mar 6, 2020
|
|
||
| double outlet_pressure = 101325.0; |
There was a problem hiding this comment.
Here's the value of pressure BC that I've now set in tests/unit/inputs/test_surrogate_input.xml
paulromano
requested changes
Mar 6, 2020
Co-Authored-By: Paul Romano <paul.k.romano@gmail.com>
paulromano
approved these changes
Mar 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new format for
enrico.xml, as discussed in #87. The new format has top-level elements for<neutronics>,<heat_fluids>, and<coupling>. Under those top-level elements, all pre-existing elements are now reorganized as sub-elements.CoupledDriverare minimal. They required no changes to the constructor's signatureHeatFluidsDriverwas changed to omit thepressure_bcparameter add an XML node parameter. This is because the<pressure_bc>element is now a subelement of<heat_fluids>, so it seemed to make sense to just pass the parent<heat_fluids>element.