Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dark-mode doesn't properly work for graphs #520

Closed
1 task
ghost opened this issue May 2, 2024 · 4 comments
Closed
1 task

[BUG] Dark-mode doesn't properly work for graphs #520

ghost opened this issue May 2, 2024 · 4 comments
Labels
type: bug Something isn't working
Milestone

Comments

@ghost
Copy link

ghost commented May 2, 2024

Description

Thanks a lot for the frontend! I really like it and I think it'll the frontend I'll be use for my personal usage in the future. In the past I've tried Koala (BetterGPT fork), LobeChat, LibreChat, and some others.

Here's about the small bug itself:

If you use the diagram tool or ask the LLM to draw a diagram right in the chat, with dark mode you won't be able to see some of the diagram features.

Here's an example diagram:

@startuml
node "TypeScript Framework" as ts

node "C++ Engine Kernel" as cpp
node "TS Engine Kernel" as tsk

node "Native Platforms\niOS, Android, Mac, Windows, etc." as native
node "Web Platforms" as web  
node "Mini-Game Platforms" as minigame

ts --> cpp
ts --> tsk
cpp --> native
tsk --> web
tsk --> minigame
@enduml

I think there are two solutions for this problem - either find/create and use PlantUML/Mermaid dark themes, or always force light mode for diagrams (or via a toggle)

Device and browser

Arch Linux, latest Brave Browser, user-agent "Mozilla/5.0 (X11; U; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.6295.214 Safari/537.36", same happens on Android 14 with Chrome.

Screenshots and more

Dark:
image
image

Light:
image
image

Willingness to Contribute

  • 🙋‍♂️ Yes, I would like to contribute a fix.
@ghost ghost added the type: bug Something isn't working label May 2, 2024
@enricoros
Copy link
Owner

Thanks. This code is SVG, produced by the PlantUML rendering service (plantUML.com).
I'll look into fixing this by having a lighter background (on charts only) when in Dark mode.

@enricoros
Copy link
Owner

This is how a diagram in PlantUML or MermaidJS will look like now.
image

This is deployed to main which will become the next stable release within a week. You can either build and run it today from main, or wait until it's out.

@enricoros
Copy link
Owner

Thanks a bunch for providing the details.

@ghost
Copy link
Author

ghost commented May 2, 2024

Thanks a lot for a quick fix!

@enricoros enricoros added this to the 1.16.0 milestone May 7, 2024
@enricoros enricoros mentioned this issue May 9, 2024
24 tasks
pAkalpa pushed a commit to pAkalpa/big-AGI that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant