Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e testing #2

Merged
merged 39 commits into from
Aug 30, 2023
Merged

add e2e testing #2

merged 39 commits into from
Aug 30, 2023

Conversation

mdtanrikulu
Copy link
Member

@mdtanrikulu mdtanrikulu commented Jul 3, 2023

note: struggled compiling contracts under windows CI, gonna take it as a separate task later.

@mdtanrikulu mdtanrikulu requested a review from Arachnid July 5, 2023 15:30
Copy link
Member

@Arachnid Arachnid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame that you had to implement CCIP-read yourself here, but aside from one minor nit, LGTM.

tests/e2e.test.ts Outdated Show resolved Hide resolved
@mdtanrikulu mdtanrikulu merged commit 5049566 into main Aug 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants