This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
Adding interface to reverse registrar #336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interaction between 0.6.0 smart contracts and the reverse registrar
|
Thanks for this! Are you able to rename to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With solidity 0.6.0 introducing breaking changes, it is not possible for smart contract using solidity 0.6.0 to import contract sources using ^0.5.0 such as those in this repository.
A solution is to, rather then importing the actual source, rely on an interface with pragma >=0.4.24 such as
ENS.sol. However, there isn't such an interface for the reverse registrar.This PR solves this by adding such an interface that can be imported by smart contract using ^0.5.0 of ^0.6.0