Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid name duplication of the enso universal launcher #10476

Closed
JaroslavTulach opened this issue Jul 8, 2024 · 2 comments · Fixed by #10535
Closed

Avoid name duplication of the enso universal launcher #10476

JaroslavTulach opened this issue Jul 8, 2024 · 2 comments · Fixed by #10535
Assignees

Comments

@JaroslavTulach
Copy link
Member

There are two executables named enso among the daily bits we produce. That's confusing and we shall fix it.

One of them is called Enso launcher. To learn about it, please visit our download page: https://github.com/enso-org/enso/releases/tag/2024.1.1 - the download is in section called Enso Engine on that page, but in fact, it is not the engine, it is the launcher!

Enso Engine

To learn more abou tthe enso launcher visit this documentation page - it contains nice description of the whole universtal launcher/updater picture...

However to benefit from the work done by

we need to find a better location for exposing native image built launcher. The idea is to rename the launcher to ensoup:

ensoup illustration

It is a nice, illustrative name derived from the rustup example that nicely describes one of the purposes of ensoup - download the distributions of Enso automatically. Once the enso in the bundle is renamed to ensoup, we can proceed with placing a native image built binary next to it under the name enso - but that's for a different PR.

@JaroslavTulach JaroslavTulach self-assigned this Jul 9, 2024
@mergify mergify bot closed this as completed in #10535 Jul 16, 2024
mergify bot pushed a commit that referenced this issue Jul 16, 2024
Closes #10476.

# Important Notes
Let's see what exactly fails on the CI and fix that then...
@JaroslavTulach
Copy link
Member Author

I've just downloaded the latest nightly and it contains the ensoup executable:

tar ftvz enso-bundle-2024.3.1-nightly.2024.7.17-linux-amd64.tar.gz  | grep enso/bin
drwxr-xr-x ci/ci             0 2024-07-17 04:29 enso/bin/
-rwxr--r-- ci/ci      58969568 2024-07-17 04:29 enso/bin/ensoup

the executable seems to work to some extend. I can ensoup new path_to_a_project and it runs. I haven't tested the other functionality (CCing @radeusgd), but in general things seem to work.

@radeusgd
Copy link
Member

I haven't tested the other functionality (CCing @radeusgd), but in general things seem to work.

I have downloaded the Windows bundle.

Seems to work OK to me. I've checked most of the functionality, incl. the installation feature and all seem to work as expected. I have only not checked the self-upgrade.

I will be starting using ensoup from now on :) 🥣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants