Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review By_Column in selectors and using Column within APIs #5153

Closed
wdanilo opened this issue Feb 5, 2023 · 6 comments · Fixed by #5646
Closed

Review By_Column in selectors and using Column within APIs #5153

wdanilo opened this issue Feb 5, 2023 · 6 comments · Fixed by #5646
Assignees
Labels
-libs Libraries: New libraries to be implemented l-types-and-statics p-low Low priority x-design
Milestone

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by James Dunkerley.
Original issue is here.


The current By_Column in selectors works by picking a matching name. This functionality should be removed.

When a column is passed to functions (such as Sum and Average) the column is only valid if in the table.
Derived columns would need to be set in the table.
Once expressions are supported they should be able to be used here.

@wdanilo wdanilo added this to the Beta Release milestone Feb 6, 2023
@jdunkerley jdunkerley removed the x-new-feature Type: new feature request label Feb 6, 2023
@jdunkerley jdunkerley moved this to ❓New in Issues Board Feb 6, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Feb 6, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to 🔧 Implementation in Issues Board Feb 9, 2023
@enso-bot
Copy link

enso-bot bot commented Feb 9, 2023

James Dunkerley reports a new STANDUP for today (2023-02-09):

Progress: Worked through recreating the Colorado COVID example within a Cloud instance. Started removing last parts where Column allowed as an argument. Also restructuring Column_Selector. It should be finished by 2023-02-13.

Next Day: Work on Excel_Workbook and SQLite File_Format.

@jdunkerley
Copy link
Member

Additionally: Add Vector_Editor attribute to Table.select_columns

@enso-bot
Copy link

enso-bot bot commented Feb 13, 2023

James Dunkerley reports a new 🔴 DELAY for today (2023-02-13):

Summary: There is 2 days delay in implementation of the Review By_Column in selectors and using Column within APIs (#5153) task.
It will cause 0 day delay for the delivery of this weekly plan.

Delay Cause: Too much time on GH stuff. Took me a while to produce investor and iteration reports. Lots of stuff on plate.

@enso-bot
Copy link

enso-bot bot commented Feb 13, 2023

James Dunkerley reports a new STANDUP for today (2023-02-13):

Progress: Tidying up the WIP I had. Investor summary, Iteration end. PR for Radek. It should be finished by 2023-02-17.

Next Day: Finish off the Column_Selector work.

@enso-bot
Copy link

enso-bot bot commented Feb 14, 2023

James Dunkerley reports a new STANDUP for today (2023-02-14):

Progress: Preparing for demo on the MIMIC dataset. Backlog work for engines and libraries. Working on sorting out the Column_Selector rework. It should be finished by 2023-02-17.

Next Day: Get the Column_Selector merged and pushed out.

@enso-bot
Copy link

enso-bot bot commented Feb 15, 2023

James Dunkerley reports a new STANDUP for today (2023-02-15):

Progress: Finished the Column_Selector work. Improved the Excel_Workbook to not reload over and over, It should be finished by 2023-02-17.

Next Day: Get PR merged and onto another issue.

@jdunkerley jdunkerley moved this from 🔧 Implementation to 👁️ Code review in Issues Board Feb 15, 2023
@mergify mergify bot closed this as completed in #5646 Feb 16, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented l-types-and-statics p-low Low priority x-design
Projects
Archived in project
2 participants