Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE must support reconnecting after laptop has been slept/hibernated #5197

Closed
wdanilo opened this issue Feb 5, 2023 · 8 comments
Closed
Assignees
Labels
-language-server p-high Should be completed in the next sprint x-new-feature Type: new feature request
Milestone

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by James Dunkerley.
Original issue is here.


Currently if the device goes to sleep when the laptop reawakes the IDE will have lost the connection to the backend.
The only option is to restart.

This scenario needs to allow auto reconnection preferably without requiring the complete rebuilding and re-execution of the project.

The backend should still have had all the results from the workflow execution so it should be possible to avoid running potentially very slow operations again from scratch.

Comments:

This is part of a much bigger task requiring trouble-less re-establishing of the connection. I will keep this ticket open, as one of the requirements. (Hubert Plociniczak - Feb 3, 2023)


@wdanilo wdanilo added this to the Beta Release milestone Feb 6, 2023
@sylwiabr sylwiabr moved this to 📤 Backlog in Issues Board Feb 7, 2023
@jdunkerley jdunkerley added p-high Should be completed in the next sprint and removed p-low Low priority labels Feb 7, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to ❓New in Issues Board Mar 28, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Mar 28, 2023
@jdunkerley jdunkerley assigned 4e6 and unassigned hubertp Apr 18, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to ❓New in Issues Board Apr 18, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Apr 18, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to 🔧 Implementation in Issues Board Apr 18, 2023
@jdunkerley jdunkerley moved this from 🔧 Implementation to 📤 Backlog in Issues Board Apr 25, 2023
@hubertp hubertp assigned hubertp and unassigned 4e6 Jul 7, 2023
@hubertp hubertp moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jul 7, 2023
@enso-bot
Copy link

enso-bot bot commented Jul 10, 2023

Hubert Plociniczak reports a new STANDUP for the provided date (2023-07-07):

Progress: Continued investigating startup performance. Hit a roadblock with reported #7240. Logging service replacement is likely the next candidate for improvement. Being reading up the current implementation needed for reconnection after sleep. It should be finished by 2023-07-12.

Next Day: Next day I will be working on the #5197 task. Continue reading on re-connection and find missing pieces in LS.

@enso-bot
Copy link

enso-bot bot commented Jul 11, 2023

Hubert Plociniczak reports a new STANDUP for yesterday (2023-07-10):

Progress: Have a small change that makes it easier to re-connect after laptop is woken up hibernation but it doesn't fix the problem. It looks like a) IDE doesn't attempt re-connection still b) (worse) it looses WebGL context after restart and the project view disappears. My change delays shutdown on LS when the last client disconnects, therefore one does not have to pay the price of startup all over again and IDE can re-use the port number of LS server that was originally assigned. That's probably all I can do on the LS-side. It should be finished by 2023-07-12.

Next Day: Next day I will be working on the #5197 task. Create a PR with LS change, create tickets for IDE.

@hubertp hubertp moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jul 12, 2023
@hubertp
Copy link
Contributor

hubertp commented Jul 12, 2023

I created a follow up ticket for IDE. On the LS side we are pretty much done, I think.

@enso-bot
Copy link

enso-bot bot commented Jul 12, 2023

Hubert Plociniczak reports a new STANDUP for yesterday (2023-07-11):

Progress: Created promised PR, figuring out how to add unit tests. Off most of the day. It should be finished by 2023-07-12.

Next Day: Next day I will be working on the #5197 task. Add unit tests, if possible.

@jdunkerley
Copy link
Member

jdunkerley commented Jul 18, 2023

IDE tickets #7255 and #5202

@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jul 18, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Jul 24, 2023
@enso-bot
Copy link

enso-bot bot commented Aug 3, 2023

Hubert Plociniczak reports a new STANDUP for the provided date (2023-07-12):

Progress: Added unit tests that exercise the language server part. Further re-connection problems will need to be resolved on the IDE side. Verifyiing 7242Analysing visualization timeouts reported by Greg (likely a duplicate of an existing issue with jobs cancelling each other). Started looking into logging infrastructure. It should be finished by 2023-07-12.

Next Day: Next day I will be working on the #7253 task. Logging replacement.

@hubertp
Copy link
Contributor

hubertp commented Aug 3, 2023

(^ late standup report)

@hubertp
Copy link
Contributor

hubertp commented Sep 5, 2023

So looks like things has gotten worse again in the past few weeks. LS still delays shutdown but somehow IDE claims to loose connection and never re-connects to the same port. Will need to investigate when it regressed. I'm guessing recreating webgl context might have something to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-language-server p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
None yet
Development

No branches or pull requests

4 participants