Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning Extension Functions #6027

Closed
jdunkerley opened this issue Mar 21, 2023 · 7 comments · Fixed by #6176
Closed

Warning Extension Functions #6027

jdunkerley opened this issue Mar 21, 2023 · 7 comments · Fixed by #6176
Assignees
Labels
-libs Libraries: New libraries to be implemented x-new-feature Type: new feature request

Comments

@jdunkerley
Copy link
Member

## Checks if any warnings (either all or of a specified type) are attached to the value.

   Arguments:
   - warning_type: The type to check if attached to the value. Defaults to any warning.
Any.has_warnings : Any -> Boolean
Any.has_warnings self warning_type=Any = ...

## Remove the warning s(either all or of a specified type) attached to the value.

   Arguments:
   - warning_type: The type to remove if attached to the value. Defaults to all warnings.
Any.remove_warnings : Any -> Any
Any.remove_warnings self warning_type=Any = ...

## Throws the first matching warning (either all or of a specified type) as a data flow error.

   Arguments:
   - warning_type: The type to throw if attached to the value. Defaults to all warnings.
Any.throw_on_warning : Any -> Any
Any.throw_on_warning self warning_type=Any = ...
@jdunkerley jdunkerley self-assigned this Mar 21, 2023
@jdunkerley jdunkerley added x-new-feature Type: new feature request -libs Libraries: New libraries to be implemented labels Mar 21, 2023
@jdunkerley jdunkerley added this to the Design Partners milestone Mar 21, 2023
@jdunkerley jdunkerley linked a pull request Mar 31, 2023 that will close this issue
5 tasks
@jdunkerley jdunkerley removed a link to a pull request Apr 1, 2023
5 tasks
@jdunkerley jdunkerley linked a pull request Apr 3, 2023 that will close this issue
5 tasks
@jdunkerley
Copy link
Member Author

Distinctly less simple than I hoped it would be...

@enso-bot
Copy link

enso-bot bot commented Apr 5, 2023

Hubert Plociniczak reports a new STANDUP for yesterday (2023-04-04):

Progress: Continued investigating the potential solution. Also addressing PR comments for execution context. Playing around with old bookclubs and filed some bugs. It should be finished by 2023-04-06.

Next Day: Next day I will be working on the #6027 task. Investigate suggestions for the potential fix.

@enso-bot
Copy link

enso-bot bot commented Apr 5, 2023

Hubert Plociniczak reports a new STANDUP for today (2023-04-05):

Progress: Warning will follow a similar method dispatch hack as dataflow errors. Almost got all tests passing, still needs more tweaks. It should be finished by 2023-04-06.

Next Day: Next day I will be working on the #6027 task. Investigate suggestions for the potential fix.

@enso-bot
Copy link

enso-bot bot commented Apr 12, 2023

Hubert Plociniczak reports a new 🔴 DELAY for yesterday (2023-04-11):

Summary: There is 6 days delay in implementation of the Warning Extension Functions (#6027) task.
It will cause 2 days delay for the delivery of this weekly plan.

Delay Cause: Holidays + figuring out the best way to deal with warnings took more time than anticipated.

@enso-bot
Copy link

enso-bot bot commented Apr 12, 2023

Hubert Plociniczak reports a new STANDUP for yesterday (2023-04-11):

Progress: Catching up after a break. Addressing PR feedback - making sure we still allow for overrides when names conflict with Warning methods, using Truffle DSL instead of node manipulation. Worked on #6227, PR ready. It should be finished by 2023-04-12.

Next Day: Next day I will be working on the #6027 task. Address PR feedback. Pick up next item in the list.

@enso-bot
Copy link

enso-bot bot commented Apr 13, 2023

Hubert Plociniczak reports a new STANDUP for yesterday (2023-04-12):

Progress: Addressed feedback based oi discussions with Jaroslav. Started investigating #6248, a follow up on previous crash with to_display_text. Discovered that we are not returning all members of Atom during polyglot calls. It should be finished by 2023-04-12.

Next Day: Next day I will be working on the #6248 task. Continue the investigation on #6248.

@enso-bot
Copy link

enso-bot bot commented Apr 28, 2023

Hubert Plociniczak reports a new STANDUP for the provided date (2023-04-06):

Progress: (late submission) Continued working on warnings. PR is updated. Startup bookclub and hit a regression (reported and revert was in place). It should be finished by 2023-04-12.

Next Day: Next day I will be working on the #6027 task. Address PR feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants