-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic widget visualization is missing suggestions for values with warnings #6045
Comments
Looks like the culprit is this delegation to a new node as done in InvokeMethodNode and InvokeCallableNode |
Hubert Plociniczak reports a new STANDUP for yesterday (2023-03-22): Progress: The insertion of the new node, when dealing with warnings, leads to a function call node not being replaced by its instrumented version. That in turn later leads to missing setup and lack of caller node. Need to figure out if this is a problem with our code or truffle. It should be finished by 2023-03-24. Next Day: Next day I will be working on the #6045 task. Investigate why no instrumentation node is being inserted. Look into the new execution context design. |
Hubert Plociniczak reports a new STANDUP for yesterday (2023-03-23): Progress: Finally managed to figure why instrumentation wasn't behaving as we expected. Turned out that insertion of nodes during runtime would produce nodes (and their children) that were never instrumentable, not only for warnings. This was because the new nodes lacked UUIDs. The actual fix is simple and ready in draft PR. The only thing missing is tests but they are not easy to set up. It should be finished by 2023-03-24. Next Day: Next day I will be working on the #6045 task. Finish tests and undraft the PR. Spend some time on bookclubs. Pick up next task. |
Hubert Plociniczak reports a new STANDUP for the provided date (2023-03-24): Progress: Figured out how to set up the test for UUID instrumentation. Had to also deal with separate compilation. It should be finished by 2023-03-24. Next Day: Next day I will be working on the #6045 task. Scheduling new tasks, testing the current state of LS, bookclub. |
Instrumentation of calls involving warning values never really worked because: 1) newly created nodes didn't set the UUID of their children 2) the instrumentable wrappers always had an empty (i.e. null) UUID and they never referred `get`/`setId` calls to their delegates On the surface, everything worked fine. Except when one actually relied on the instrumentation of values with warnings for proper setup. Then no instrumentation (replacement of nodes) was performed due to empty UUID (as required by `hasTag` of `FunctionCallInstrumentationNode`). Closes #6045. Discovered in #5893.
Follow up on #5983, .
Notice missing selector when dealing with values that have warnings:
The text was updated successfully, but these errors were encountered: