Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE from union type syntax error #6401

Closed
GregoryTravis opened this issue Apr 24, 2023 · 1 comment · Fixed by #6415
Closed

NPE from union type syntax error #6401

GregoryTravis opened this issue Apr 24, 2023 · 1 comment · Fixed by #6415
Assignees
Labels

Comments

@GregoryTravis
Copy link
Contributor

A missing type literal causes an NPE:

-fan_out_to_columns : Table -> Text | Integer -> (Any -> Vector Any) -> Integer | Nothing -> Problem_Behavior -> Table | Nothing
+fan_out_to_columns : Table -> Text | Integer -> (Any -> Vector Any) -> | Nothing -> Problem_Behavior -> Table | Nothing

Steps to reproduce:

$ git checkout bug/gmt/npe-missing-return-type
$ built-distribution/enso-engine-0.0.0-dev-macos-amd64/enso-0.0.0-dev/bin/enso --run test/Table_Tests/src/In_Memory/Split_Tokenize_Spec.enso --in-project test/Table_Tests --no-ir-caches

Expected result: runs tests normally.

Actual result:

Execution finished with an error: java.lang.NullPointerException
        at <java> org.enso.compiler.TreeToIr.translateType(TreeToIr.java:1087)
        at <java> org.enso.compiler.TreeToIr.translateType(TreeToIr.java:1098)
        at <java> org.enso.compiler.TreeToIr.translateType(TreeToIr.java:1098)
        at <java> org.enso.compiler.TreeToIr.translateModuleSymbolImpl(TreeToIr.java:329)
        at <java> org.enso.compiler.TreeToIr.translateModuleSymbol(TreeToIr.java:228)
        at <java> org.enso.compiler.TreeToIr.translateModule(TreeToIr.java:206)
        at <java> org.enso.compiler.TreeToIr.translate(TreeToIr.java:93)
        at <java> org.enso.compiler.EnsoCompiler.generateIR(EnsoCompiler.java:48)
        at <java> org.enso.compiler.Compiler.uncachedParseModule(Compiler.scala:587)
        at <java> org.enso.compiler.Compiler.parseModule(Compiler.scala:552)
[...]
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Apr 25, 2023
@hubertp hubertp removed the triage label Apr 25, 2023
@JaroslavTulach JaroslavTulach linked a pull request Apr 25, 2023 that will close this issue
2 tasks
@JaroslavTulach JaroslavTulach moved this from 📤 Backlog to 👁️ Code review in Issues Board Apr 25, 2023
@mergify mergify bot closed this as completed in #6415 Apr 25, 2023
mergify bot pushed a commit that referenced this issue Apr 25, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Apr 25, 2023
@enso-bot
Copy link

enso-bot bot commented Apr 26, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-04-25):

Progress: - TreeToIr NPE bugfix: #6415

Next Day: Processing backlog & meetings

Google Docs
| Attendees: Notes Post clean up of private still long lists. Any methods show up for all types. Need to hide overrides so only listed once by tagging them as PRIVATE. We should fold methods so only shown once No need to list `to_text` for the type and for `Any`. Favorites currently o...
Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants