Convert vector elements when needed #7271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
requested review from
jdunkerley,
radeusgd and
GregoryTravis
as code owners
JaroslavTulach
commented
Jul 12, 2023
| type Hello | ||
| Say (msg:Text) | ||
|
|
||
| formulate : Vector Hello -> Text |
There was a problem hiding this comment.
First of all there is a static method that operates on a Vector with Hello elements.
| @@ -115,4 +116,11 @@ spec = | |||
| Test.specify "should not allow currying" <| | |||
| Panic.recover Any (Foo.from) . catch Any .to_display_text . should_equal "Conversion currying without `that` argument is not supported." | |||
|
|
|||
| Test.specify "Use conversions to in Conversion_Use module" <| | |||
| Hello.formulate [ Hello.Say "Proper", Hello.Say "Type" ] . should_equal "ProperType" | |||
| Hello.formulate [ Foo.Value "Perform", Bar.Value "Conversion" ] . should_equal "PERFORM conversion!" | |||
There was a problem hiding this comment.
This line invokes the static formulate method with non-Hello instances, but these instances have conversions methods to Hello defined in this module. See below...
|
|
||
| formulate : Vector Hello -> Text | ||
| formulate arr = | ||
| process (t:Text) (h:Hello) = t + h.msg |
There was a problem hiding this comment.
By using ascribed arguments in a function that folds over the Vector, we request each element to be Hello or converted to Hello.
JaroslavTulach
added
the
CI: No changelog needed
4 tasks
jdunkerley
approved these changes
Jul 12, 2023
JaroslavTulach
added
the
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adds a test case demonstrating the use of automatic conversions when processing vector elements.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR: