Add endpoint for downloading a project #7291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
changed the title
lib/scala/pkg/src/main/java/org/enso/pkg/archive/EnsoProjectArchive.java
Outdated
Show resolved
Hide resolved
lib/scala/pkg/src/main/java/org/enso/pkg/archive/CloseArchiveEntryException.java
Show resolved
Hide resolved
lib/scala/pkg/src/main/java/org/enso/pkg/archive/EnsoProjectArchiveException.java
Show resolved
Hide resolved
| import org.enso.pkg.Package$; | ||
|
|
||
| /** A file visitor that builds a tar archive out of visited files. */ | ||
| public final class TarArchiveBuildingFileVisitor implements FileVisitor<Path> { |
There was a problem hiding this comment.
I'd expect this to be an implementation detail class and I'd keep it package private.
lib/scala/pkg/src/test/scala/org/enso/pkg/archive/EnsoProjectArchiveSpec.scala
Show resolved
Hide resolved
| complete(StatusCodes.NotFound) | ||
| case Success(Right(Some(archive))) => | ||
| complete( | ||
| HttpEntity( |
There was a problem hiding this comment.
Shouldn't we also write a test for this endpoint?
There was a problem hiding this comment.
All the tricky logic is about the archive building. This one is pretty straightforward. I'll see if I can mock the project repository and add a test then
| /** Error when trying to close an enso-project archive entry. */ | ||
| public final class CloseArchiveEntryException extends EnsoProjectArchiveException { | ||
|
|
||
| public CloseArchiveEntryException(IOException cause) { |
There was a problem hiding this comment.
If the class (and other similar cases) is only constructed in the same package, then you may want to have package private constructors.
JaroslavTulach
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #7194
Changelog:
/projects/{project_id}/enso_projectHTTP endpoint returning an.enso-projectarchive structure.enso-project.tar.gzarchivepatha required fieldImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.