Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnsoBigInteger should be a BigInteger polyglot type #7213

Closed
5 tasks done
Akirathan opened this issue Jul 5, 2023 · 3 comments · Fixed by #7420
Closed
5 tasks done

EnsoBigInteger should be a BigInteger polyglot type #7213

Akirathan opened this issue Jul 5, 2023 · 3 comments · Fixed by #7420
Assignees

Comments

@Akirathan
Copy link
Member

Akirathan commented Jul 5, 2023

#7176 integrates GraalVM 17.0.7 (23.0.0 JDK 17) into Enso, which brings support for BigInteger polyglot type. After we refactor EnsoBigInteger to be a proper BigInteger interop type (by implementing fitsInBigInteger message), we should measure the performance impact - for example the impact of a sum of a column that is made of big integers, instead of longs.

This is a follow-up issue of #5300

Tasks

@enso-bot
Copy link

enso-bot bot commented Jul 30, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-07-29):

Progress: - BigInteger interop test: ca73109

  • multiply by long: 21ef3b3
  • boundary conversion: 4f9d8ca It should be finished by 2023-08-01.

Next Day: BigInteger & Interop with Python

@enso-bot
Copy link

enso-bot bot commented Aug 1, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-07-31):

Progress: - BigInteger

Next Day: BigInteger & Interop with Python

GitHub
Closes #7323 Pull Request Description There are a lot of Enso-only benchmarks in test/Benchmarks project. These benchmarks are not run on the CI (they are, but only in dry-run). We want to run thes...

@enso-bot
Copy link

enso-bot bot commented Aug 2, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-08-01):

Progress: - book club: https://discord.com/channels/401396655599124480/1133705401800601675/1135840766409834567

  • BigInteger fixes
  • Avoid WithWarnings conversion: 335f469
  • Chat with Pawel B. about project-manager in cloud
  • planning next iteration It should be finished by 2023-08-01.

Next Day: BigInteger & Interop with Python

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

@JaroslavTulach JaroslavTulach moved this from 📤 Backlog to 👁️ Code review in Issues Board Aug 3, 2023
@mergify mergify bot closed this as completed in #7420 Aug 3, 2023
mergify bot pushed a commit that referenced this issue Aug 3, 2023
Fixes #7213 by reacting to new `isBigInteger` and `asBigInteger` messages. Adjusts tests to require `BigInteger` when appropriate. `EnsoBigInteger` no longer extends `Number`. Enso tests to come.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants