Engine fatal crash when adding a simple node

[jdunkerley]

2023-07-19_13-20-02.mp4

Trying to add a simple _ - 2 node to take 2 off a column.

Causes the backend to crash with an assertion failed (left == right).

[jdunkerley]

Book_Club_20230719.enso-project.tar.gz

Project file.

To make it crash just choose Month Index
Add a new node and type - 2
Backend crashes.

[JaroslavTulach]

I assume (based on following logs) that this is a failure caused by the Rust part of the Enso parser:

[jdunkerley]

thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
  left: `[Operator { precedence: Precedence { value: 80 }, associativity: Left, opr: Binary { tokens: [[0:"."] Operator { properties: OperatorProperties { binary_infix_precedence: Some(Precedence { value: 80 }), unary_prefix_precedence: None, lhs_section_termination: None, is_compile_time_operation: false, is_right_associative: false, is_modifier: false, is_decimal: false, is_type_annotation: false, is_assignment: false, is_arrow: false, is_sequence: false, is_suspension: false, is_annotation: false, is_dot: true, is_special: false, is_token_joiner: false } }], lhs_section_termination: None } }]`,
 right: `[]`', lib\rust\parser\src\syntax\operator.rs:346:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  EXCEPTION_UNCAUGHT_CXX_EXCEPTION (0xe06d7363) at pc=0x00007ffa92434b2c, pid=43040, tid=20884
#
# JRE version: OpenJDK Runtime Environment GraalVM CE 22.3.1 (17.0.6+10) (build 17.0.6+10-jvmci-22.3-b13)
# Java VM: OpenJDK 64-Bit Server VM GraalVM CE 22.3.1 (17.0.6+10-jvmci-22.3-b13, mixed mode, sharing, tiered, jvmci, jvmci compiler, compressed oops, compressed class ptrs, g1 gc, windows-amd64)
# Problematic frame:
# C  [KERNELBASE.dll+0x64b2c]
#
# No core dump will be written. Minidumps are not enabled by default on client versions of Windows
#
# An error report file with more information is saved as:
# C:\Repos\Enso\ide\hs_err_pid43040.log
#
# If you would like to submit a bug report, please visit:
#   https://github.com/oracle/graal/issues
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#

[kazcw]

The crash occurs when parsing a certain invalid syntax. The edit in question does not result in invalid syntax; sending the incorrect expression to the backend is probably a result of #7357. This bug will just track correcting handling of the syntax error in the parser.

[enso-bot]

Keziah Wesley reports a new STANDUP for yesterday (2023-07-24):

Progress: Debugged the issue and started implementing a solution. It should be finished by 2023-07-26.

Next Day: Next day I will be working on the #7335 task. Continue work on the family of parser edge cases related to this lexer special case.

[enso-bot]

Keziah Wesley reports a new STANDUP for today (2023-07-25):

Progress: Finished implementation that passes new tests. It should be finished by 2023-07-26.

Next Day: Next day I will be working on the #7335 task. Look in to a remaining test failure. Then start on the next task.