Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error message on panic. #7376

Closed
Tracked by #8032
farmaazon opened this issue Jul 24, 2023 · 12 comments · Fixed by #7507
Closed
Tracked by #8032

Display error message on panic. #7376

farmaazon opened this issue Jul 24, 2023 · 12 comments · Fixed by #7507
Assignees
Labels
d-hard Difficulty: significant prior knowledge required g-dashboard p-medium Should be completed in the next few sprints
Milestone

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Jul 24, 2023

When there is a panic inside WASM code, we should display an error message informing about the fact and asking for reporting an issue (and the panic message to put in the report).

Recovering or reopening project are welcome, but not in scope of this task, as these may be hard to implement. If not implemented, the view should go back to the dashboard and the project should be closed.

@farmaazon farmaazon added d-hard Difficulty: significant prior knowledge required p-high Should be completed in the next sprint -gui g-dashboard labels Jul 24, 2023
@farmaazon farmaazon added this to the Beta Release milestone Jul 24, 2023
@farmaazon farmaazon changed the title Display error message on panic (no handling, just ask user for restarting app and report a problem) Display error message on panic. Jul 24, 2023
@enso-bot
Copy link

enso-bot bot commented Jul 28, 2023

Paweł Grabarz reports a new STANDUP for yesterday (2023-07-27):

Progress: Started working on the task. Found the place where we load the wasm, now reading more how ensogl-pack works. It should be finished by 2023-08-02.

@enso-bot
Copy link

enso-bot bot commented Aug 1, 2023

Paweł Grabarz reports a new STANDUP for yesterday (2023-07-31):

Progress: Trying out various flags of wasm-bindgen, to see if I can somehow reinitialize wasm module and clean up all registered event handlers from the old one. "weak-refs" seems helpful, as it gets rid of the js-side heap. It should be finished by 2023-08-02.

@enso-bot
Copy link

enso-bot bot commented Aug 8, 2023

Paweł Grabarz reports a new 🔴 DELAY for yesterday (2023-08-07):

Summary: There is 6 days delay in implementation of the Display error message on panic. (#7376) task.
It will cause 6 days delay for the delivery of this weekly plan.

Delay Cause: Underestimated the wasm module unloading complexity, delay spilled over the weekend.

@enso-bot
Copy link

enso-bot bot commented Aug 8, 2023

Paweł Grabarz reports a new STANDUP for yesterday (2023-08-07):

Progress: Finished implementing and styling panic message window. Marked PR for review. It should be finished by 2023-08-08.

@enso-bot
Copy link

enso-bot bot commented Aug 9, 2023

Paweł Grabarz reports a new STANDUP for yesterday (2023-08-08):

Progress: Addressed PR review comments, added automatic filling of bug report template fields. It should be finished by 2023-08-08.

@enso-bot
Copy link

enso-bot bot commented Aug 17, 2023

Paweł Grabarz reports a new STANDUP for the provided date (2023-07-28):

Progress: Went through the application loading and initialization code, now figuring out how to implement proper restart after crashing. The wasm-pack generated JS module keeps private references to JS objects, and I'm still figuring out how to clean that up properly. It should be finished by 2023-08-08.

@enso-bot
Copy link

enso-bot bot commented Aug 17, 2023

Paweł Grabarz reports a new STANDUP for the provided date (2023-08-01):

Progress: Tried messing around with various wasm-bindgen configurations, but nothing allowed me to automatically clear all registered handlers. I will have to find a way to do it myself. Alternatively, we can force reload the page, but it will make debugging harder. It should be finished by 2023-08-08.

@enso-bot
Copy link

enso-bot bot commented Aug 17, 2023

Paweł Grabarz reports a new STANDUP for the provided date (2023-08-02):

Progress: Decided to redirect registering all event handlers and callbacks through a JS module that allows clearing them purely on JS side. Created that module and started adjusting existing code to use it. It should be finished by 2023-08-08.

@enso-bot
Copy link

enso-bot bot commented Aug 17, 2023

Paweł Grabarz reports a new STANDUP for the provided date (2023-08-03):

Progress: Continuing refactoring all callback closures to use methods with automatic JS-side cleanup. It should be finished by 2023-08-08.

@enso-bot
Copy link

enso-bot bot commented Aug 17, 2023

Paweł Grabarz reports a new STANDUP for the provided date (2023-08-04):

Progress: Finished refactoring JS callback closures. Started working on actually displaying the caught panic. It should be finished by 2023-08-08.

@hubertp hubertp reopened this Aug 31, 2023
@hubertp
Copy link
Contributor

hubertp commented Aug 31, 2023

PR has been reverted #7708

@farmaazon farmaazon added p-medium Should be completed in the next few sprints and removed p-high Should be completed in the next sprint labels Sep 25, 2023
@somebody1234
Copy link
Contributor

I'm assuming this is [wontfix] because GUI1 is soon to be deprecated

@somebody1234 somebody1234 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d-hard Difficulty: significant prior knowledge required g-dashboard p-medium Should be completed in the next few sprints
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants