Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Filter_Conditions for is_nan, is_infinite and equals_ignore_case #8045

Closed
4 tasks done
radeusgd opened this issue Oct 13, 2023 · 3 comments · Fixed by #8539
Closed
4 tasks done

Additional Filter_Conditions for is_nan, is_infinite and equals_ignore_case #8045

radeusgd opened this issue Oct 13, 2023 · 3 comments · Fixed by #8539
Assignees
Labels
-libs Libraries: New libraries to be implemented x-new-feature Type: new feature request

Comments

@radeusgd
Copy link
Member

radeusgd commented Oct 13, 2023

As in the title, we need to add 3 more Filter_Condition variants:

Equals_Ignore_Case (to : Text | Any)
Is_Nan
Is_Infinite
  • Add variants
  • Add tests for Vector, Table filtering
  • Update the code for creating the filters
  • Update the code for resolving Filter_Condition Column_Ref
@enso-bot
Copy link

enso-bot bot commented Dec 14, 2023

Radosław Waśko reports a new STANDUP for yesterday (2023-12-13):

Progress: Added new Filter Conditions, added relevant tests. It should be finished by 2023-12-15.

Next Day: Next day I will be working on the same task. Fix some remaining test failures; look into next task; compare Sieve benchmarks

@radeusgd radeusgd moved this from 🔧 Implementation to 👁️ Code review in Issues Board Dec 14, 2023
@enso-bot
Copy link

enso-bot bot commented Dec 14, 2023

Radosław Waśko reports a new STANDUP for yesterday (2023-12-14):

Progress: Fixing some broken tests, CR. Updating other PRs after review. Tinkering with Return type checks and how to give better context info in type error. AoC. It should be finished by 2023-12-15.

Next Day: Next day I will be working on the #8544 task. Fix some remaining test failures; look into next task; compare Sieve benchmarks

@radeusgd
Copy link
Member Author

I forgot to update a few:

Progress: Fixing some broken tests, CR. Updating other PRs after review. Tinkering with Return type checks and how to give better context info in type error. Comparing Sieve benchmarks to measure overhead of type checks. AoC. It should be finished by 2023-12-15.

Next Day: Next task

@mergify mergify bot closed this as completed in #8539 Dec 16, 2023
mergify bot pushed a commit that referenced this issue Dec 16, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants