Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and Test Enso User and Cloud Utils #8354

Closed
9 tasks done
jdunkerley opened this issue Nov 21, 2023 · 2 comments · Fixed by #8511
Closed
9 tasks done

Review and Test Enso User and Cloud Utils #8354

jdunkerley opened this issue Nov 21, 2023 · 2 comments · Fixed by #8511
Assignees
@radeusgd
Labels
-libs Libraries: New libraries to be implemented l-cloud-integration Enso Cloud integration work

Comments

@jdunkerley
Copy link
Member

jdunkerley commented Nov 21, 2023 •
edited by radeusgd
Loading

Utils:

  • Override the ENSO_CLOUD_API_URI
  • Test getAPIRootURI.
  • Add support for overriding the credential location.
  • Put a file in correct place and verify credential reading.
  • Test authorization_header.

Enso_User:

  • Test deserialising from a known JSON structure
  • Test all properties.

Cloud Mock

  • Create a cloud mock which checks a known token and returns specific json files at specific paths.
  • Test Enso_User.list and Enso_User.current against this mock.
@jdunkerley jdunkerley added -libs Libraries: New libraries to be implemented l-cloud-integration Enso Cloud integration work labels Nov 21, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Nov 21, 2023
@radeusgd radeusgd moved this from 📤 Backlog to 🔧 Implementation in Issues Board Dec 7, 2023
@enso-bot enso-bot bot mentioned this issue Dec 8, 2023
Closed
16 tasks
@enso-bot
Copy link

enso-bot bot commented Dec 11, 2023

Radosław Waśko reports a new STANDUP for the provided date (2023-12-08):

Progress: Started adding tests for cloud mock, fighting with an old bug (#7117), but managed to find a sensible workaround. Catching up on Advent of Code. Implemented a PoC for return type checking. It should be finished by 2023-12-13.

Next Day: Next day I will be working on the same task. Continue working on the cloud mock tests.

@radeusgd radeusgd mentioned this issue Dec 11, 2023
Merged
5 tasks
@radeusgd radeusgd moved this from 🔧 Implementation to 👁️ Code review in Issues Board Dec 11, 2023
@radeusgd radeusgd linked a pull request Dec 11, 2023 that will close this issue
Add tests for Enso Cloud auth + simple API mock for Enso_User #8511
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Dec 12, 2023

Radosław Waśko reports a new STANDUP for yesterday (2023-12-11):

Progress: Prepared PR with cloud mock tests for basic credentials setup and Enso_User type. AoC. It should be finished by 2023-12-13.

Next Day: Next day I will be working on the #7635 task. Pick up a next small task.

@mergify mergify bot closed this as completed in #8511 Dec 19, 2023
mergify bot pushed a commit that referenced this issue Dec 19, 2023
@radeusgd
Add tests for Enso Cloud auth + simple API mock for Enso_User (#8511)
724f8d2 
- Closes #8354
- Extends `simple-httpbin` with a simple mock of the Cloud API (currently it checks the token and serves the `/users` endpoint).
- Renames `simple-httpbin` to `http-test-helper`.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radeusgd radeusgd

Labels
-libs Libraries: New libraries to be implemented l-cloud-integration Enso Cloud integration work
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for Enso Cloud auth + simple API mock for Enso_User enso-org/enso
2 participants
@radeusgd @jdunkerley