Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference rewriting #8683

Closed
kazcw opened this issue Jan 5, 2024 · 5 comments
Closed

Reference rewriting #8683

kazcw opened this issue Jan 5, 2024 · 5 comments
Assignees
Labels
-gui d-hard Difficulty: significant prior knowledge required p-highest Should be completed ASAP

Comments

@kazcw
Copy link
Contributor

kazcw commented Jan 5, 2024

AST APIs need to support two distinct kinds of update to an expression:

  • Modify an expression, maintaining its current ID (as done by the current MutableModule.set).
  • Substitute an expression, replacing any existing reference to it with a reference to a new (provided) expression.

The new substitution operation will provide a way to handle the case of an expression being moved within the module without the need to alter its ID.

@kazcw kazcw self-assigned this Jan 5, 2024
@enso-bot
Copy link

enso-bot bot commented Jan 6, 2024

Keziah Wesley reports a new STANDUP for yesterday (2024-01-04):

Progress: Designing/implementing reference-rewriting APIs and introducing some linear typing to prevent "temporarily" invalid module states, which are not compatible with the reference rewriting API. It should be finished by 2024-01-08.

Next Day: Next day I will be working on the #8683 task. Finish implementing reference rewriting and related APIs.

@farmaazon farmaazon added d-hard Difficulty: significant prior knowledge required p-highest Should be completed ASAP -gui labels Jan 8, 2024
@kazcw kazcw mentioned this issue Jan 9, 2024
5 tasks
@enso-bot
Copy link

enso-bot bot commented Jan 9, 2024

Keziah Wesley reports a new STANDUP for the last Friday (2024-01-05):

Progress: Finish reference rewriting. It should be finished by 2024-01-08.

Next Day: Next day I will be working on the #8683 task. Finish task, resume implementing sync.

@enso-bot
Copy link

enso-bot bot commented Jan 9, 2024

Adam Obuchowicz reports a new 🔴 DELAY for today (2024-01-09):

Summary: There is 2 days delay in implementation of the Reference rewriting (#8683) task.
It will cause 2 days delay for the delivery of this weekly plan.

Delay Cause: Kaz took day off, and issues were hard to debug by me and Paweł

@enso-bot
Copy link

enso-bot bot commented Jan 9, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-01-09):

Progress: Pair-debugged the Kaz's PR about AST reference rewriting. Had some discussions, and made a working code. It should be finished by 2024-01-10.

Next Day: Next day I will be working on the same task. try to fix last issues related to widget updating; then do next stuff from backlog

mergify bot pushed a commit that referenced this issue Jan 10, 2024
@enso-bot
Copy link

enso-bot bot commented Jan 11, 2024

Keziah Wesley reports a new STANDUP for yesterday (2024-01-09):

Progress: Debugging issues with ID stability. It should be finished by 2024-01-10.

Next Day: Next day I will be working on the #8237 task. Resume implementing sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-hard Difficulty: significant prior knowledge required p-highest Should be completed ASAP
Projects
Archived in project
Development

No branches or pull requests

3 participants