Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify downloading Enso project locally works #9176

Closed
hubertp opened this issue Feb 26, 2024 · 4 comments
Closed

Verify downloading Enso project locally works #9176

hubertp opened this issue Feb 26, 2024 · 4 comments
Assignees
Labels
-project-manager local-project-manager Tasks related to local project manager improvements

Comments

@hubertp
Copy link
Contributor

hubertp commented Feb 26, 2024

Part of local project manager's improvements epic.

Apparently the feature has been supported on the backend for a while but needs to be verified. Problems have been reported.

@hubertp hubertp added the local-project-manager Tasks related to local project manager improvements label Feb 26, 2024
@4e6
Copy link
Contributor

4e6 commented Feb 28, 2024

Project manager exposes the projects/{project-id}/enso-project HTTP endpoint for downloading projects.

The Download menu entry of the projects list redirects to the /api/project-manager/projects/${asset.id}/enso-project

download.download(
`./api/project-manager/projects/${asset.id}/enso-project`,
`${asset.title}.enso-project`
)

Which is being rewritten by the Electron server to the appropriate project manager URL

} else if (requestUrl.startsWith('/api/project-manager/')) {
const actualUrl = new URL(
requestUrl.replace(
/^\/api\/project-manager/,
GLOBAL_CONFIG.projectManagerHttpEndpoint
)

URL rewriting is not implemented in the dev server (when GUI started with npm run dev, and therefore the Download menu entry only works in the desktop app.

@enso-bot
Copy link

enso-bot bot commented Feb 28, 2024

Dmitry Bushev reports a new STANDUP for yesterday (2024-02-27):

Progress: Finishing working on the Yjs task. Cleaned up the server implementation. Simplified the event emitter interface by re-using the event listener functions. Created the PR. Switched to the task. Investigated the library management functionality of the language server and ensured that it was covered with tests. It should be finished by 2024-02-28.

Next Day: Next day I will be working on the #9176 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Feb 28, 2024

Dmitry Bushev reports a new STANDUP for today (2024-02-28):

Progress: Continue working on the task. Investigated the download feature of the dashboard. Found out why it does not work in the dev server. Described in the issue. It should be finished by 2024-02-28.

Next Day: Next day I will be working on the #9176 task. Continue working on the task

@hubertp
Copy link
Contributor Author

hubertp commented Mar 19, 2024

So the verification bit is done. I create a follow up ticket for you @somebody1234 #9482

@hubertp hubertp closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-project-manager local-project-manager Tasks related to local project manager improvements
Projects
Archived in project
Development

No branches or pull requests

3 participants