Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cycles in the serialized IR structure #9361

Closed
radeusgd opened this issue Mar 11, 2024 · 5 comments · Fixed by #9972
Closed

Support cycles in the serialized IR structure #9361

radeusgd opened this issue Mar 11, 2024 · 5 comments · Fixed by #9972
Assignees
@JaroslavTulach
Labels
-compiler x-new-feature Type: new feature request

Comments

@radeusgd
Copy link
Member

As part of #8652 I'm extending the bindings map with additional metadata that results in a cycle within the IR. Currently, that causes the IR serialization to fail with StackOverflow, because there is no support for cycles.

We want to expand our IR serialization to support such looping.

I've added a few tests demonstrating the expected behaviour on the branch wip/persistance-loops.
@radeusgd radeusgd added x-new-feature Type: new feature request -compiler labels Mar 11, 2024
@JaroslavTulach JaroslavTulach mentioned this issue Mar 11, 2024
Merged
2 tasks
This was referenced Mar 15, 2024
Closed
Closed
@radeusgd radeusgd mentioned this issue Mar 28, 2024
Merged
5 tasks
@radeusgd radeusgd mentioned this issue Apr 29, 2024
Open
9 tasks
@JaroslavTulach JaroslavTulach mentioned this issue May 16, 2024
Merged
2 tasks
@enso-bot
Copy link

enso-bot bot commented May 17, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-16):

Progress: - persistance with cycles: #9972

@enso-bot
Copy link

enso-bot bot commented May 18, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-17):

Progress: - cycles in persistance: https://github.com/enso-org/enso/pull/9972/files#r1604646728

GitHub
Pull Request Description Fixes #9361 by delaying storing of Persistance.Reference instances and creating their table at the end of the stream. Checklist Please ensure that the following checklist h...

@mergify mergify bot closed this as completed in #9972 May 18, 2024
mergify bot pushed a commit that referenced this issue May 18, 2024
@JaroslavTulach
Table of Persistance.Reference at the end of the stream (#9972)
fe28c23 
Fixes #9361 by delaying storing of `Persistance.Reference` instances and creating their table at the end of the stream.
@enso-bot
Copy link

enso-bot bot commented May 19, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-18):

Progress: - reviewing Greg's #9950

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

@enso-bot
Copy link

enso-bot bot commented May 20, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-19):

Progress: - solving the Parse loading problem: 773af10

Discord
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
GitHub
Pull Request Description The goal of this PR is to execute enso --run test/Base_Tests. That requires us to properly register all polyglot java import classes for reflective access. That's done ...

@enso-bot
Copy link

enso-bot bot commented May 21, 2024 •
edited by unfurl-links bot
Loading

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-20):

Progress: - ./runner --run test/Base_Tests ^Text works: #9997 (comment)

GitHub
Pull Request Description The goal of this PR is to execute ./runner --run test/Base_Tests ^Text. That requires us to properly register all polyglot java import classes for reflective access. That&#...

@radeusgd radeusgd mentioned this issue May 27, 2024
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Jun 10, 2024
@radeusgd
Fixes to Persistance (#10101)
99a1d05 
- Follow-up to #9361
- Enables assertions and fixes `count` check
- Tests and fixes null references
- Tests and fixes serializing a deserialized structure - by saving the id of the `Persistance` corresponding to the entry
- After the change to how we determine which `Persistance` instance to use, the most specific one is now used (based on the saved id). This has an unfortunate consequence that `Seq` which is most of the time represented by a subtype of `List`, is now using `PersistScalaList` which is not lazy.
- To alleviate that, we no longer use `Seq` to store some field lazily and instead use a dedicated type for that purpose: `InlineReference`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaroslavTulach JaroslavTulach

Labels
-compiler x-new-feature Type: new feature request
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Table of Persistance.Reference at the end of the stream enso-org/enso
2 participants
@radeusgd @JaroslavTulach