Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The type shown on the output port should not be fully qualified #9416

Closed
Tracked by #9181
AdRiley opened this issue Mar 14, 2024 · 6 comments · Fixed by #9784
Closed
Tracked by #9181

The type shown on the output port should not be fully qualified #9416

AdRiley opened this issue Mar 14, 2024 · 6 comments · Fixed by #9784
Assignees
Labels
-gui x-new-feature Type: new feature request
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented Mar 14, 2024

  • The output type should move from the output port to the visualisation
  • When we show the type on the output port we should just show the last part of its name and a tooltip should show the full name

image

So in this example just Table

Image

@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels Mar 14, 2024
@AdRiley AdRiley added this to the Beta Release milestone Mar 14, 2024
@farmaazon
Copy link
Contributor

I remember in GUI2 the full name was shown after hovering ~2 seconds. Do we want to restore it? I think that sometimes the FQN may be helpful, if there is many types with same name.

@AdRiley
Copy link
Member Author

AdRiley commented Mar 14, 2024

Which types have the same name? Struggling to think when this would be useful.

@farmaazon
Copy link
Contributor

Anyone can put type Table in his project.

@AdRiley
Copy link
Member Author

AdRiley commented Mar 14, 2024

But typical users of the product that we are building will not. I don't want to block features because of edge cases that will likely never happen.

@farmaazon
Copy link
Contributor

But this "show on lag" feature should be fairly simple to implement. And I expect the name collisions will happen once user starts publishing their libraries. Let's discuss it during refinement.

@farmaazon
Copy link
Contributor

Refinement note: Take care if the custom vis icons won't obscure the type label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants