Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move node type to visualization container #9784

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Move node type to visualization container #9784

merged 1 commit into from
Apr 30, 2024

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Apr 24, 2024

Pull Request Description

node-types.mov
  • When a visualization is shown, the node's type name is displayed, unqualified, at the right end of the visualization toolbar.
  • When the unqualified type name is hovered, a tooltip shows the full type name.
  • Hovering output ports no longer shows a type name.

Closes #9416.

Important Notes

Refinement note: Take care if the custom vis icons won't obscure the type label.

The node type is a child of the same flexbox as the custom toolbar, so there shouldn't be any problem.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 24, 2024
@kazcw kazcw self-assigned this Apr 24, 2024
@kazcw kazcw marked this pull request as draft April 29, 2024 13:18
@kazcw kazcw marked this pull request as ready for review April 29, 2024 13:18
@kazcw kazcw merged commit 6655d5f into develop Apr 30, 2024
37 checks passed
@kazcw kazcw deleted the node-types branch April 30, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The type shown on the output port should not be fully qualified
2 participants