Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Opensearch telemetry to Electron App #9730

Closed
AdRiley opened this issue Apr 17, 2024 · 12 comments · Fixed by #9951
Closed

Add basic Opensearch telemetry to Electron App #9730

AdRiley opened this issue Apr 17, 2024 · 12 comments · Fixed by #9951
Assignees
Labels
-gui x-new-feature Type: new feature request
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented Apr 17, 2024

Events to track: open/close product/project (4 in total)

@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels Apr 17, 2024
@AdRiley AdRiley added this to the Beta Release milestone Apr 17, 2024
@AdRiley AdRiley added the s-info-needed Status: more information needed from submitter label Apr 17, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Apr 18, 2024
@farmaazon
Copy link
Contributor

farmaazon commented Apr 18, 2024

Refinement notes:

  • The timestamp, user ID and URL to cloud endpoint should be passed by dashboard to GUI
  • We should use Elasticsearch (implementation may be taken from old GUI)

@farmaazon farmaazon changed the title Add basic telemetry to Electron App Add basic Opensearch telemetry to Electron App Apr 30, 2024
@Frizi Frizi moved this from 📤 Backlog to 🔧 Implementation in Issues Board May 6, 2024
@Frizi Frizi self-assigned this May 6, 2024
@enso-bot
Copy link

enso-bot bot commented May 9, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-06):

Progress: Early proof of concept implementation for sending events from GUI through Cloud API. It should be finished by 2024-05-13.

@enso-bot
Copy link

enso-bot bot commented May 9, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-07):

Progress: Fixed GUI double-initialization to be able to send project opening events correctly. Added event logger implementation to dashboard and used it to mirror GA app open/close events. It should be finished by 2024-05-13.

@enso-bot
Copy link

enso-bot bot commented May 10, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-08):

Progress: Refactored GUI side event logging to use dashboard backend implementation, noticed problems with access tokens not being refreshed. It should be finished by 2024-05-13.

@farmaazon farmaazon removed the s-info-needed Status: more information needed from submitter label May 14, 2024
@Frizi Frizi moved this from 🔧 Implementation to 👁️ Code review in Issues Board May 14, 2024
@mergify mergify bot closed this as completed in #9951 May 27, 2024
mergify bot pushed a commit that referenced this issue May 27, 2024
…eact component. (#9951)

fixes #9730

Added a `logEvent` method to remote backend implementation in dashboard. Added an always-present remote backend instance that can be used for logging even when running a local project (intentional behavior).

# Important Notes
Because the backend implementation requires access to always fresh session token, the logger needs to be periodically updated on GUI side, so it can continue to function. To accomplish that, I simplified the app loading logic to treat GUI as an ordinary react component, so its props can be updated with normal react rendering flow. That refactor also removed the dynamic GUI asset loading code that was only needed for Rust GUI.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board May 27, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 28, 2024
@enso-bot
Copy link

enso-bot bot commented Jun 13, 2024

Paweł Grabarz reports a new 🔴 DELAY for the provided date (2024-06-10):

Summary: There is 14 days delay in implementation of the Add basic Opensearch telemetry to Electron App (#9730) task.
It will cause 14 days delay for the delivery of this weekly plan.

Delay Cause: Complications with sharing session data and cloud backend querying code between GUI and dashboard due to very janky dynamic app loading mechanism, which had to be refactored.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-09):

Progress: Refactoring GUI loading code in dashboard to use vue-in-react component rendering, so dynamic props can be passed down. It should be finished by 2024-05-27.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-10):

Progress: Continuing GUI loading refactor. It should be finished by 2024-05-27.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-13):

Progress: Successfully loaded GUI in react as component, fixed GUI double-initialization bug. Currently the bridge requires loading both frameworks synchronously as part of single chunk, which I still plan to fix. It should be finished by 2024-05-27.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-14):

Progress: Removed all pinia usages in GUI to allow using default vue app constructor without any plugins, which simplifies loading sequence and allows splitting vue and react chunks. It should be finished by 2024-05-27.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-22):

Progress: Started addressing review of dashboard changes and fixing numerous linting issues. It should be finished by 2024-05-27.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-23):

Progress: Meeting with engine about visualization updates and reactive cache. Finished addressing review comments for dashboard changes, still working on broken tests. It should be finished by 2024-05-27.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-24):

Progress: Fixed affected dashboard tests, moved GUI root DOM into the dashboard view hierarchy, instead of always rendering in top-level hardcoded element. It should be finished by 2024-05-27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants