Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid global compilation locks with visualizations to speedup feedback #9736

Closed
hubertp opened this issue Apr 18, 2024 · 15 comments
Closed

Avoid global compilation locks with visualizations to speedup feedback #9736

hubertp opened this issue Apr 18, 2024 · 15 comments
Assignees
Labels
-compiler p-high Should be completed in the next sprint

Comments

@hubertp
Copy link
Contributor

hubertp commented Apr 18, 2024

This ticket is another attempt at making visualizations snappier by attempting to enable multithreaded execution.
Previous ticket went a slightly different direction and it makes little sense to continue reporting progress in it.
Previously we have translated our JSON parser from JS to a Java one, to allow parallel execution at all.

The main idea is to avoid/limit lock usage during upserting visualization job which limits our possibility of running visualizations quicker. Unfortunately once disabled, it reveals all sorts of problems preventing us from multi-threaded execution e.g. mutation in MethodScope.registerMethod leads to race-conditions.

@enso-bot
Copy link

enso-bot bot commented Apr 30, 2024

Hubert Plociniczak reports a new STANDUP for yesterday (2024-04-29):

Progress: Started investigating compiler to implement parallel execution in visualizations. Investigation issues in the cloud offering between GUI and LS. It should be finished by 2024-05-03.

Next Day: Next day I will be working on the #9736 task. Continue the investigation.

@enso-bot
Copy link

enso-bot bot commented May 1, 2024

Hubert Plociniczak reports a new STANDUP for yesterday (2024-04-30):

Progress: Continued refactoring ModuleScope to immutable and mutable parts. Seems to present in every part of the compiler. It should be finished by 2024-05-03.

Next Day: Next day I will be working on the #9736 task. Continue the investigation.

@enso-bot
Copy link

enso-bot bot commented May 2, 2024

Hubert Plociniczak reports a new STANDUP for yesterday (2024-05-01):

Progress: Some progress in refactoring, working on a draft PR.Tried debugging cloud issues, no progress so far. It should be finished by 2024-05-03.

Next Day: Next day I will be working on the #9736 task. Continue the investigation.

@enso-bot
Copy link

enso-bot bot commented May 3, 2024

Hubert Plociniczak reports a new STANDUP for yesterday (2024-05-02):

Progress: Reviewing ydoc server work, created #9841 with some follow up. Debugging cloud issues and continued refactoring work. It should be finished by 2024-05-03.

Next Day: Next day I will be working on the #9736 task. Continue the investigation.

@enso-bot
Copy link

enso-bot bot commented May 27, 2024

Hubert Plociniczak reports a new 🔴 DELAY for the provided date (2024-05-24):

Summary: There is 28 days delay in implementation of the Avoid global compilation locks with visualizations to speedup feedback (#9736) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Ongoing work into visualizations. Attempting various optimizations.

@enso-bot
Copy link

enso-bot bot commented May 27, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-05-24):

Progress: Addressing feedback, identifying locations where scope must be built. Resurrecting #8270. It should be finished by 2024-05-31.

Next Day: Next day I will be working on the #9736 task. Continue the investigation.

@enso-bot
Copy link

enso-bot bot commented May 29, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-05-27):

Progress: Resurrected #8270 as a new PR (#10095). Continued with ModuleScope refactoring. It should be finished by 2024-05-31.

Next Day: Next day I will be working on the #9736 task. Continue refactoring.

@enso-bot
Copy link

enso-bot bot commented May 29, 2024

Hubert Plociniczak reports a new STANDUP for yesterday (2024-05-28):

Progress: Still refactoring ModuleScope while taking into account reviews on draft solution. The proliferation of ModuleScope in our codebase is not helping. It should be finished by 2024-05-31.

Next Day: Next day I will be working on the #9736 task. Continue refactoring.

@enso-bot
Copy link

enso-bot bot commented May 31, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-05-29):

Progress: Still rewriting ModuleScope, also investigated regression in nightly. Created #10123 with a hotfix It should be finished by 2024-05-31.

Next Day: Next day I will be working on the #9736 task. Continue refactoring.

@enso-bot
Copy link

enso-bot bot commented Jun 2, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-05-30):

Progress: Investigating follow up for #10123, nightly still broken. Threw away some work on to start from scratch. Not much visible progress, yet. It should be finished by 2024-05-31.

Next Day: Next day I will be working on the #9736 task. Continue refactoring.

@enso-bot
Copy link

enso-bot bot commented Jun 3, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-05-31):

Progress: Ditched most of the troubling API, leaving only a few places where builder is exposed. Few tests are failing. It should be finished by 2024-05-31.

Next Day: Next day I will be working on the #9736 task. Undraft PR

@enso-bot
Copy link

enso-bot bot commented Jun 5, 2024

Hubert Plociniczak reports a new 🔴 DELAY for the provided date (2024-06-03):

Summary: There is 6 days delay in implementation of the Avoid global compilation locks with visualizations to speedup feedback (#9736) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: ModuleScope has leaked into every possible corner of codebase, making it hard to make any minor refactorings. One more delay to finish up the PR

@enso-bot
Copy link

enso-bot bot commented Jun 5, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-06-03):

Progress: Final cleanup to PR. It should be finished by 2024-06-06.

Next Day: Next day I will be working on the #9736 task. Undraft PR, address PR comments.

@enso-bot
Copy link

enso-bot bot commented Jun 5, 2024

Hubert Plociniczak reports a new STANDUP for yesterday (2024-06-04):

Progress: Undrafted PR, addressing comments, testing. Reduced time. It should be finished by 2024-06-06.

Next Day: Next day I will be working on the #9736 task. Finish addressing PR comments.

@enso-bot
Copy link

enso-bot bot commented Jun 7, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-06-05):

Progress: Final changes to ModuleScope refactoring. Resurrecting Jackson replacement work in #10035. It should be finished by 2024-06-06.

Next Day: Next day I will be working on the #9789 task. Continue integrating new JSON serde

@hubertp hubertp closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler p-high Should be completed in the next sprint
Projects
Archived in project
Development

No branches or pull requests

1 participant