Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize right-dock state in module metadata #9938

Closed
kazcw opened this issue May 13, 2024 · 6 comments · Fixed by #9990
Closed

Synchronize right-dock state in module metadata #9938

kazcw opened this issue May 13, 2024 · 6 comments · Fixed by #9990
Assignees
@Frizi
Labels
-gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Milestone
Beta Release

Comments

@kazcw
Copy link
Contributor

kazcw commented May 13, 2024 •
edited by farmaazon
Loading

  • Store the docs-opening state in the same place where camera position is (per method)
  • If there is no info about it, just open the doc panel if there's any documentation to show.
  • We don't want to store it in the file, because it should not be synchronized between users.
@kazcw kazcw added the -gui label May 13, 2024
@farmaazon farmaazon added this to the Beta Release milestone May 14, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board May 14, 2024
@farmaazon farmaazon added p-high Should be completed in the next sprint d-easy Difficulty: little prior knowledge required labels May 14, 2024
@kazcw
Copy link
Contributor Author

kazcw commented May 14, 2024

We should also store right-dock width.

@Frizi Frizi moved this from 📤 Backlog to 🔧 Implementation in Issues Board May 14, 2024
@Frizi Frizi self-assigned this May 14, 2024
@Frizi Frizi mentioned this issue May 17, 2024
Merged
4 tasks
@Frizi Frizi moved this from 🔧 Implementation to 👁️ Code review in Issues Board May 17, 2024
@farmaazon farmaazon moved this from 👁️ Code review to 🟢 Accepted in Issues Board May 20, 2024
@mergify mergify bot closed this as completed in #9990 May 27, 2024
mergify bot pushed a commit that referenced this issue May 27, 2024
@Frizi
Generalize keyed local storage for more client side graph-editor data (…
ca916b8 
…#9990)

Fixes #9938

The documentation panel openness and size state are saved in localStorage. On initial graph entry, the documentation panel is automatically opened if the graph's function is documented.
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 28, 2024
@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-15):

Progress: Created basic implementation of remembering documentation panel state. Currently missing a way to detect if visualization exists, waiting for other PR containing that to be merged. It should be finished by 2024-05-27.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-16):

Progress: Refactoring localstorage graph data implementation to not be navigator specific. It should be finished by 2024-05-27.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-17):

Progress: Finished local storage sync refactor and merged in changes required for checking if documentation is present. It should be finished by 2024-05-27.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-20):

Progress: Did a few large code reviews, started addressing review of doc panel syncing. It should be finished by 2024-05-27.

@enso-bot
Copy link

enso-bot bot commented Jun 26, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-05-21):

Progress: Finished addressing reviews and merge conflicts. It should be finished by 2024-05-27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Frizi Frizi

Labels
-gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Generalize keyed local storage for more client side graph-editor data enso-org/enso
3 participants
@Frizi @kazcw @farmaazon