Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component browser test. #10001

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix component browser test. #10001

merged 1 commit into from
May 20, 2024

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

One test was randomly failing - we deselected node, and expected small plus button will disappear despite the node could be still hovered by mouse.

Actually, I don't know how did it stay with us so long.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@farmaazon farmaazon self-assigned this May 20, 2024
@farmaazon farmaazon added CI: No changelog needed Do not require a changelog entry for this PR. --bug Type: bug --regression Important: regression -gui labels May 20, 2024
@Frizi Frizi added the CI: Ready to merge This PR is eligible for automatic merge label May 20, 2024
@jdunkerley jdunkerley merged commit c3976f7 into develop May 20, 2024
36 of 39 checks passed
@jdunkerley jdunkerley deleted the wip/farmaazon/fix-test branch May 20, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug --regression Important: regression -gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants