Fix adding nodes in collapsed functions #10009
Merged
+85
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9963. - Fix a bug printing blank lines at the beginning of a module. - Remove a redundant data-property from `GraphNode`.
kazcw
added
the
CI: No changelog needed
farmaazon
approved these changes
May 21, 2024
| @@ -48,7 +48,6 @@ const uploadingFiles = computed<[FileName, File][]>(() => { | |||
| :node="node" | |||
| :edited="id === graphStore.editedNodeInfo?.id" | |||
| :graphNodeSelections="props.graphNodeSelections" | |||
| :data-node="id" | |||
There was a problem hiding this comment.
It is very helpful in debugging. We could use :data-testid="node(${id})" if you want to have something standardized.
There was a problem hiding this comment.
This is a duplicate; the GraphNode component defines data-node-id with the same value.
Comment on lines
+9
to
+15
| ['node1 = 123', '*'], | ||
| ['node1 = 123', '*', 'node1'], | ||
| ['node1 = 123', '', '*', 'node1'], | ||
| ['*', 'node1'], | ||
| ['', '*', 'node1'], | ||
| ['*', '## Return value', 'node1'], | ||
| ['*', '## Return value', '', 'node1'], |
There was a problem hiding this comment.
Add a case of adding a node to an empty block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Insert new nodes before the block's terminal expression-statement, if present.
Fixes #9963.
Important Notes
GraphNode.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.