Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow picking non-existing files in write component #10047

Merged
merged 2 commits into from
May 24, 2024

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

Fixes #9984

Added a flag to File_Browse widget configuration specifying if we require an existing file. Also, the FileBrowserWidget will match against all "Writable_File", also displaying Save dialog.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • [ ] Unit tests have been written where possible.

Copy link
Contributor

@somebody1234 somebody1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving Electron desktop app changes

@farmaazon farmaazon added CI: Ready to merge This PR is eligible for automatic merge labels May 24, 2024
@mergify mergify bot merged commit 8ac0ee4 into develop May 24, 2024
38 checks passed
@mergify mergify bot deleted the wip/farmaazon/write-file-dialog branch May 24, 2024 09:21
MrFlashAccount pushed a commit that referenced this pull request May 25, 2024
Fixes #9984

Added a flag to `File_Browse` widget configuration specifying if we require an existing file. Also, the FileBrowserWidget will match against all "Writable_File", also displaying Save dialog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose File doesn't work for write component
6 participants