Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors of Dialogs, Popover styles, button sizes and Text #10199

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Refactors of Dialogs, Popover styles, button sizes and Text #10199

merged 1 commit into from
Jun 7, 2024

Conversation

MrFlashAccount
Copy link
Contributor

Pull Request Description

In this PR:

  1. Now button has proper sized icons, size of the button is also alighned with the grid
  2. Migrate ResizableTextContentEditableInput to Text component
  3. Migrate Dialog to variants API
  4. Did another attemt to make text more reusable. Now instead of using paddings, we use ::before and ::after to make text better aligned inside a grid

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@MrFlashAccount MrFlashAccount self-assigned this Jun 6, 2024
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Jun 6, 2024
This was referenced Jun 6, 2024
Merged
Merged
Merged
@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/migrations branch 2 times, most recently from 1b4c467 to b005a72 Compare June 7, 2024 06:51
@MrFlashAccount MrFlashAccount added the CI: Ready to merge This PR is eligible for automatic merge label Jun 7, 2024
@mergify mergify bot merged commit 7a20bdc into develop Jun 7, 2024
34 checks passed
@mergify mergify bot deleted the wip/sergeigarin/migrations branch June 7, 2024 08:10
mergify bot pushed a commit that referenced this pull request Jun 7, 2024
@MrFlashAccount
Make Settings Sidebar a bit dimmer (#10201)
f74c790 
https://github.com/enso-org/enso/assets/61194245/98eaac8b-2284-4b98-a8f8-a9fe19d3227b


This PR partially depends on #10199
mergify bot pushed a commit that referenced this pull request Jun 16, 2024
@MrFlashAccount
Initial Support for paywalls (#10202)
04551f4 
This PR introduces:
1. Set of Paywall components: PaywallButton, PaywallDialog
2. Adds Devtools
3. Implement Paywall Configuration

This PR partially depends on #10199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somebody1234 somebody1234 somebody1234 approved these changes

@PabloBuchu PabloBuchu Awaiting requested review from PabloBuchu PabloBuchu is a code owner

@indiv0 indiv0 Awaiting requested review from indiv0 indiv0 is a code owner

Assignees

@MrFlashAccount MrFlashAccount

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrFlashAccount @somebody1234