Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/mk/default visualisations for connections #10340

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Wip/mk/default visualisations for connections #10340

merged 10 commits into from
Jun 24, 2024

Conversation

marthasharkey
Copy link
Contributor

@marthasharkey marthasharkey commented Jun 21, 2024 •
edited
Loading

Pull Request Description

Allows users to click on the index column of a row/value and the row/value will be extracted into another node

7473

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@marthasharkey marthasharkey marked this pull request as ready for review June 21, 2024 15:22
kazcw
kazcw approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@kazcw kazcw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Cool feature! It definitely deserves a changelog entry.

kazcw
kazcw reviewed Jun 21, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@marthasharkey marthasharkey force-pushed the wip/mk/default-visualisations-for-connections branch from 637b583 to 880f6e5 Compare June 24, 2024 09:00
@marthasharkey marthasharkey added the CI: Ready to merge This PR is eligible for automatic merge label Jun 24, 2024
@mergify mergify bot merged commit 5233390 into develop Jun 24, 2024
37 checks passed
@mergify mergify bot deleted the wip/mk/default-visualisations-for-connections branch June 24, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazcw kazcw kazcw approved these changes

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees
No one assigned
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marthasharkey @kazcw