-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect compilation while benchmarking #10574
Conversation
Nice "side-effect" of this change is: We can see the errors from the compiler like this one:
I guess we should finally fix this |
There seems to be 26 compilation detected messages. Those benchmarks might benefit from increasing the warmup time. Update: there seems to be (at least) hundred "compilation detected" messages in the new run (with 0862a0f). |
0862a0f fixes the problem with too deep inlining in |
The benchmarks finish without errors, but some results are really skewed: as can be seen the second iteration is marked as |
engine/runtime/src/main/java/org/enso/interpreter/runtime/data/Type.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to be able to see the compilation problems in the benchmarks :)
5427549
to
00d6f2c
Compare
00d6f2c
to
5acbda0
Compare
We have a usage of blacklisted string concatenation method. Hidden behind |
Final benchmark run scheduled. It just dumps info, it doesn't throw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the fact that the Truffle engine compilation is logged into System.err
and no Exception is thrown from within the @Teardown
benchmark method, as that might cause some issue with result reporting. I hope this will enable us to set better parameters for the benchmarks.
|
Pull Request Description
Enables
engine.TruffleCompilation
instd-benchmarks
, collects the logs and dumps compilation into toSystem.err
when a benchmark is influenced by dynamic compilation.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,