Add drilldown to XML #10824
Merged
Add drilldown to XML #10824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marthasharkey
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley,
Frizi,
farmaazon,
vitvakatu and
kazcw
as code owners
GregoryTravis
approved these changes
Aug 15, 2024
kazcw
approved these changes
Aug 15, 2024
Comment on lines
368
to
369
| const castSelector = | ||
| castValueTypes === 'number' && !isNaN(Number(selector)) ? Number(selector) : selector |
There was a problem hiding this comment.
This could be done at the call site to keep the getAstPattern interface simpler.
|
Looks great - why not have it on XML_Document as well :) |
marthasharkey
added
the
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This adds the drilldown behaviour to XML_Elements.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.