Update Project Name Validation #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustosz
approved these changes
Mar 12, 2021
iamrecursion
pushed a commit
that referenced
this pull request
Mar 16, 2021
PR moves all the project validation logic to the `org.enso.pkg.validation` module and updates the project manager to use the logic from the new module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #1555
PR moves all the project validation logic to the
org.enso.pkg.validationmodule and updates the project manager to use the logic from the new module.Changelog:
feat: add
org.enso.pkg.validationcontaingin project name validation logicfeat: update project-manager project creation and project renaming functions to use the unified validation logic
Important Notes
Checklist
Please include the following checklist in your PR: