Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc Runtime Fixes #1633

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Misc Runtime Fixes #1633

merged 3 commits into from
Mar 30, 2021

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Mar 30, 2021 •
edited
Loading

Pull Request Description

Misc runtime fixes discovered when debugging the visualization updates.

Changelog:

  • fix: visualization commands are executed asynchronously. Add extra locking to ensure that the order of commands is preserved.
  • fix: Location filter excludes lambda locations in function arguments

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Bug p-high Should be completed in the next sprint labels Mar 30, 2021
@4e6 4e6 self-assigned this Mar 30, 2021
iamrecursion
iamrecursion suggested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of this code isn't exception safe and hence can deadlock. Please fix it.

.../runtime/src/main/scala/org/enso/interpreter/instrument/command/AttachVisualisationCmd.scala Outdated Show resolved Hide resolved
.../runtime/src/main/scala/org/enso/interpreter/instrument/command/DetachVisualisationCmd.scala Outdated Show resolved Hide resolved
.../runtime/src/main/scala/org/enso/interpreter/instrument/command/ModifyVisualisationCmd.scala Outdated Show resolved Hide resolved
@4e6 4e6 merged commit c32780f into main Mar 30, 2021
@4e6 4e6 deleted the wip/db/runtime-fixes branch March 30, 2021 09:11
iamrecursion pushed a commit that referenced this pull request Apr 7, 2021
@4e6 @iamrecursion
Misc Runtime Fixes (#1633)
0e955b1 
Misc runtime fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@4e6 4e6

Labels
p-high Should be completed in the next sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4e6 @iamrecursion