Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Language Server API for Libraries #1853

Merged
merged 8 commits into from
Jul 13, 2021
Merged

Update Language Server API for Libraries #1853

merged 8 commits into from
Jul 13, 2021

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jul 12, 2021 •
edited
Loading

Pull Request Description

Closes #1764

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@radeusgd radeusgd self-assigned this Jul 12, 2021
@radeusgd radeusgd added Category: Backend w-docs Website: Documentation p-high Should be completed in the next sprint labels Jul 12, 2021
@radeusgd
Copy link
Member Author

Saving a reminder that we need to discuss how to specify library metadata for publishing - description, tagline etc.

I think we could just add endpoints get/set library metadata, but I'm not completely sure about this.

cc: @MichaelMauderer

iamrecursion
iamrecursion approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the thing we discussed, LGTM.

@radeusgd radeusgd merged commit 8f57d67 into main Jul 13, 2021
@radeusgd radeusgd deleted the wip/rw/ls-api-update branch July 13, 2021 14:01
iamrecursion pushed a commit that referenced this pull request Jul 15, 2021
@radeusgd @iamrecursion
Update Language Server API for Libraries (#1853)
4cbba08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@MichaelMauderer MichaelMauderer MichaelMauderer approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@kustosz kustosz Awaiting requested review from kustosz

Assignees

@radeusgd radeusgd

Labels
p-high Should be completed in the next sprint w-docs Website: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library Related API Design for the Language Server
3 participants
@radeusgd @MichaelMauderer @iamrecursion