Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Language Server API Implementations / Mocks #1875

Merged
merged 27 commits into from
Jul 17, 2021
Merged

New Language Server API Implementations / Mocks #1875

merged 27 commits into from
Jul 17, 2021

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jul 15, 2021 •
edited
Loading

Pull Request Description

Closes #1776

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@radeusgd radeusgd self-assigned this Jul 15, 2021
@radeusgd radeusgd added Category: Backend p-high Should be completed in the next sprint labels Jul 15, 2021
@radeusgd radeusgd force-pushed the wip/rw/ls-api-implementation-or-mock branch from 8032d92 to f2ad813 Compare July 15, 2021 19:42
@radeusgd radeusgd marked this pull request as ready for review July 16, 2021 13:14
4e6
4e6 approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

engine/language-server/src/main/scala/org/enso/languageserver/libraries/LibraryApi.scala Show resolved Hide resolved
iamrecursion
iamrecursion approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, conditional on @4e6 doing a full review.

RELEASES.md Outdated Show resolved Hide resolved
build.sbt Show resolved Hide resolved
lib/scala/distribution-manager/src/main/scala/org/enso/distribution/EditionManager.scala Outdated Show resolved Hide resolved
lib/scala/pkg/src/main/scala/org/enso/pkg/Config.scala Show resolved Hide resolved
@radeusgd radeusgd merged commit 86fcd86 into main Jul 17, 2021
@radeusgd radeusgd deleted the wip/rw/ls-api-implementation-or-mock branch July 17, 2021 14:49
radeusgd added a commit that referenced this pull request Jul 19, 2021
@radeusgd
New Language Server API Implementations / Mocks (#1875)
7c28117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@4e6 4e6 4e6 approved these changes

@kustosz kustosz Awaiting requested review from kustosz

Assignees

@radeusgd radeusgd

Labels
p-high Should be completed in the next sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the Package Manager API to use for the IDE
3 participants
@radeusgd @4e6 @iamrecursion