Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stdlib Improvements #1963

Merged
merged 6 commits into from
Aug 19, 2021
Merged

Stdlib Improvements #1963

merged 6 commits into from
Aug 19, 2021

Conversation

kustosz
Copy link
Contributor

@kustosz kustosz commented Aug 19, 2021

Pull Request Description

  1. Filling missing values from columns
  2. Allow column zip to not skip missing values
  3. Add a duplicate count method for columns
  4. Add a week_of_year method on dates
  5. Allow concatenating multiple tables instead of just 2.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@kustosz kustosz added Type: Enhancement p-highest Should be completed ASAP labels Aug 19, 2021
@kustosz kustosz self-assigned this Aug 19, 2021
iamrecursion
iamrecursion approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Just a couple of cosmetic things.

distribution/lib/Standard/Base/0.2.26-SNAPSHOT/src/Data/Time/Date.enso Outdated Show resolved Hide resolved
test/Table_Tests/src/Column_Spec.enso Outdated Show resolved Hide resolved
kustosz and others added 3 commits August 19, 2021 11:30
@kustosz @iamrecursion
Update distribution/lib/Standard/Base/0.2.26-SNAPSHOT/src/Data/Time/D…
7097c61 
…ate.enso

Co-authored-by: Ara Adkins <iamrecursion@users.noreply.github.com>
@kustosz @iamrecursion
Update test/Table_Tests/src/Column_Spec.enso
724c001 
Co-authored-by: Ara Adkins <iamrecursion@users.noreply.github.com>
@kustosz
fix utf8 conversion
98ded17
@kustosz kustosz merged commit 4536ed9 into main Aug 19, 2021
@kustosz kustosz deleted the wip/mk/stdlib_stuff branch August 19, 2021 12:55
iamrecursion pushed a commit that referenced this pull request Aug 19, 2021
@kustosz @iamrecursion
Stdlib Improvements (#1963)
f343b38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@kustosz kustosz

Labels
p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kustosz @iamrecursion