Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate value parsing with Delimited file reading #3463

Merged
merged 9 commits into from
May 24, 2022
Merged

Integrate value parsing with Delimited file reading #3463

merged 9 commits into from
May 24, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented May 20, 2022 •
edited
Loading

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/182200028

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

@radeusgd radeusgd self-assigned this May 20, 2022
Base automatically changed from wip/radeusgd/table-parse-auto-182199966 to develop May 20, 2022 15:08
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-parse-182200028 branch from 71b52e3 to fac6753 Compare May 23, 2022 10:12
@radeusgd radeusgd marked this pull request as ready for review May 23, 2022 10:12
jdunkerley
jdunkerley requested changes May 24, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally

One slight change to avoid creating lots of objects

test/Table_Tests/src/Delimited_Read_Spec.enso Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/read/QuoteHelper.java Outdated Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/parsing/problems/ProblemAggregator.java Outdated Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/read/QuoteHelper.java Show resolved Hide resolved
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-parse-182200028 branch from 266b810 to f3f1d28 Compare May 24, 2022 10:25
@radeusgd radeusgd requested a review from jdunkerley May 24, 2022 10:26
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label May 24, 2022
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-parse-182200028 branch from db79e8f to c9d7d60 Compare May 24, 2022 12:44
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-parse-182200028 branch from 95d37af to efc7e0e Compare May 24, 2022 14:02
@mwu-tow mwu-tow merged commit ec1b072 into develop May 24, 2022
@mwu-tow mwu-tow deleted the wip/radeusgd/delimited-parse-182200028 branch May 24, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 4e6 approved these changes

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach is a code owner

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radeusgd @4e6 @jdunkerley @mwu-tow