Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Encoding support when writing Delimited files #3564

Merged
merged 15 commits into from
Jul 7, 2022
Merged

Custom Encoding support when writing Delimited files #3564

merged 15 commits into from
Jul 7, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jul 5, 2022 •
edited
Loading

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/182545847

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide dist and ./run ide watch.

@radeusgd radeusgd self-assigned this Jul 5, 2022
@radeusgd radeusgd marked this pull request as ready for review July 5, 2022 16:14
jdunkerley
jdunkerley reviewed Jul 5, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publishing a couple of comments before refreshing,

distribution/lib/Standard/Base/0.0.0-dev/src/System/File.enso Outdated
## We ignore any warnings raised by the `bytes` method, because if the
original Unicode replacement character failed to encode, the `bytes`
method will have replaced it with the simple `?` sign which should be
available in all encodings. And this is exactly the behavior we wan:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
available in all encodings. And this is exactly the behavior we wan:
available in all encodings. And this is exactly the behavior we want

std-bits/base/src/main/java/org/enso/base/Encoding_Utils.java Outdated Show resolved Hide resolved
@radeusgd radeusgd force-pushed the wip/radeusgd/reporitng-stream-encoder branch from 4c21055 to d7ac60a Compare July 5, 2022 16:26
jdunkerley
jdunkerley approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight question but generally looks good

std-bits/base/src/main/java/org/enso/base/encoding/ReportingStreamEncoder.java Show resolved Hide resolved
@radeusgd radeusgd force-pushed the wip/radeusgd/reporitng-stream-encoder branch from 0f9d31e to 574e8ac Compare July 6, 2022 15:26
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jul 6, 2022
@mergify mergify bot merged commit 7c94fa6 into develop Jul 7, 2022
@mergify mergify bot deleted the wip/radeusgd/reporitng-stream-encoder branch July 7, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 4e6 approved these changes

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radeusgd @4e6 @jdunkerley