-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Period Start and End functions to Date and DateTime #3695
Add Period Start and End functions to Date and DateTime #3695
Conversation
import java.time.temporal.Temporal; | ||
import java.time.temporal.TemporalAdjusters; | ||
|
||
public class Date_Period_Utils implements TimeUtilsBase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdunkerley do you think I should add some doc comments? Seems a bit 'naked' without them but OTOH I'd say the name of the function seems to be pretty self explanatory so I'm not sure if the comments would add any clarity. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the SBT build formatting
41b8b52
to
3de8f31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor rename and a suggestion.
But looks good.
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Date.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Data/Time/Time_Of_Day.enso
Outdated
Show resolved
Hide resolved
I could not fully test the autumn DST switch case as the overlapped timelines are not handled properly in polyglot which makes our Enso Date_Time unable to express one of the two instants in time there (2:30 am after the DST switch is not expressible, it gets converted back to 2:30 am before switch which is an hour earlier). Reported this at oracle/graal#4918 |
Some changes not working yet - WIP
39828dc
to
b728f05
Compare
Pull Request Description
Implements https://www.pivotaltracker.com/story/show/183081152
Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.