Missing foreign language generates proper Enso error. #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akirathan
force-pushed
the
wip/akirathan/engine-crash-183238936
branch
from
a462842
to
41ded64
Compare
Akirathan
commented
Oct 14, 2022
engine/runtime-language-epb/src/main/java/org/enso/interpreter/epb/node/ForeignEvalNode.java
Show resolved
Hide resolved
Akirathan
commented
Oct 14, 2022
| RuntimeOptions.LANGUAGE_HOME_OVERRIDE, | ||
| Paths.get("../../distribution/component").toFile().getAbsolutePath() | ||
| ).build(); | ||
| this.ctx = Context.newBuilder("enso") |
There was a problem hiding this comment.
I tried here this.ctx = Context.newBuilder("enso", "js"), but it appears that even with "js" as permitted language, engine does not see "js", even though I have it installed. @hubertp Do you have any suggestions how to include "js" language here? It's not that important, I just wanted to add another test that would successfully call js foreign method, but would fail on python foreign method.
Akirathan
force-pushed
the
wip/akirathan/engine-crash-183238936
branch
from
41ded64
to
ac9c763
Compare
Akirathan
requested review from
4e6,
JaroslavTulach and
hubertp
as code owners
JaroslavTulach
approved these changes
Oct 14, 2022
...ime-language-epb/src/main/java/org/enso/interpreter/epb/runtime/ForeignParsingException.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/test/java/org/enso/interpreter/test/ForeignMethodInvokeTest.java
Show resolved
Hide resolved
engine/runtime-language-epb/src/main/java/org/enso/interpreter/epb/node/ForeignEvalNode.java
Outdated
Show resolved
Hide resolved
engine/runtime-language-epb/src/main/java/org/enso/interpreter/epb/node/ForeignEvalNode.java
Show resolved
Hide resolved
Akirathan
force-pushed
the
wip/akirathan/engine-crash-183238936
branch
from
ac9c763
to
0f0928e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Trying to invoke a foreign method with non-installed language (either not enabled in the Truffle
Context, or not installed in the GraalVM distribution) results inPolyglot_Error, rather than crashing the entire engine.Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide buildand./run ide watch.