Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update drop_missing_rows to filter_blank_rows API. #3805

Merged
merged 16 commits into from
Oct 18, 2022
Merged

Update drop_missing_rows to filter_blank_rows API. #3805

merged 16 commits into from
Oct 18, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Oct 17, 2022 •
edited
Loading

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/183390042 and https://www.pivotaltracker.com/story/show/183390370

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@radeusgd radeusgd self-assigned this Oct 17, 2022
@radeusgd radeusgd marked this pull request as ready for review October 17, 2022 19:06
@radeusgd radeusgd force-pushed the wip/radeusgd/filter-blank-rows-183390042 branch 2 times, most recently from 14646fd to 4393c2f Compare October 18, 2022 10:02
@radeusgd radeusgd force-pushed the wip/radeusgd/filter-blank-rows-183390042 branch from 4393c2f to 00209b6 Compare October 18, 2022 13:36
@jdunkerley
Copy link
Member

Looks really good to me.

@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Oct 18, 2022
@mergify mergify bot merged commit 17f7398 into develop Oct 18, 2022
@mergify mergify bot deleted the wip/radeusgd/filter-blank-rows-183390042 branch October 18, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeusgd @jdunkerley