Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate component browser sections for every namespace libraries are imported from #4044

Merged

Conversation

galin-enso
Copy link
Contributor

@galin-enso galin-enso commented Jan 12, 2023

Pull Request Description

This PR adds new sections to the component browser section navigator bar. The sections are based on the namespaces from which libraries are imported. Selecting a namespace section from the navigator bar highlights the modules from that namespace. Selecting a module from a different namespace switches the navigator bar indicator to the correct namespace category. The currently selected namespace is also shown as the root of the breadcrumbs.

unknown_2023.01.12-19.03.mp4

For a new project where only the Standard namespace exists the only visible change is the breadcrumbs. Adding for example additional modules in the project src folder will create them in the local namespace, this namespace will show up as a separate navigator section.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@galin-enso galin-enso marked this pull request as ready for review January 13, 2023 09:00
Copy link
Member

@wdanilo wdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just second Adam's comment. I browsed the code and didn't see anything else, so I'm approving.

galin-enso and others added 4 commits January 18, 2023 08:25
…361' of github.com:enso-org/enso into wip/galin-enso/cb-separate-section-per-namespace-183803361
app/gui/src/controller/searcher/component.rs Outdated Show resolved Hide resolved
app/gui/src/controller/searcher/component.rs Outdated Show resolved Hide resolved
app/gui/src/controller/searcher/component.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@vitvakatu vitvakatu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, QA passed

@galin-enso galin-enso added the CI: Ready to merge This PR is eligible for automatic merge label Jan 23, 2023
@mergify mergify bot merged commit aa99511 into develop Jan 23, 2023
@mergify mergify bot deleted the wip/galin-enso/cb-separate-section-per-namespace-183803361 branch January 23, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants