-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate component browser sections for every namespace libraries are imported from #4044
Merged
mergify
merged 50 commits into
develop
from
wip/galin-enso/cb-separate-section-per-namespace-183803361
Jan 23, 2023
Merged
Separate component browser sections for every namespace libraries are imported from #4044
mergify
merged 50 commits into
develop
from
wip/galin-enso/cb-separate-section-per-namespace-183803361
Jan 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mespace-183803361
…mespace-183803361
…mespace-183803361
…mespace-183803361
…mespace-183803361
…mespace-183803361
…mespace-183803361
…mespace-183803361
galin-enso
requested review from
MichaelMauderer,
wdanilo,
farmaazon and
mwu-tow
as code owners
January 13, 2023 09:00
farmaazon
requested changes
Jan 13, 2023
app/gui/view/component-browser/component-list-panel/src/navigator.rs
Outdated
Show resolved
Hide resolved
app/gui/view/component-browser/component-list-panel/src/navigator.rs
Outdated
Show resolved
Hide resolved
app/gui/view/component-browser/component-list-panel/grid/src/content.rs
Outdated
Show resolved
Hide resolved
app/gui/view/component-browser/component-list-panel/grid/src/lib.rs
Outdated
Show resolved
Hide resolved
wdanilo
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just second Adam's comment. I browsed the code and didn't see anything else, so I'm approving.
…mespace-183803361
…mespace-183803361
…361' of github.com:enso-org/enso into wip/galin-enso/cb-separate-section-per-namespace-183803361
…mespace-183803361
farmaazon
approved these changes
Jan 19, 2023
app/gui/view/component-browser/component-list-panel/grid/src/lib.rs
Outdated
Show resolved
Hide resolved
vitvakatu
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, QA passed
app/gui/view/component-browser/component-list-panel/src/navigator.rs
Outdated
Show resolved
Hide resolved
mergify
bot
deleted the
wip/galin-enso/cb-separate-section-per-namespace-183803361
branch
January 23, 2023 11:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds new sections to the component browser section navigator bar. The sections are based on the namespaces from which libraries are imported. Selecting a namespace section from the navigator bar highlights the modules from that namespace. Selecting a module from a different namespace switches the navigator bar indicator to the correct namespace category. The currently selected namespace is also shown as the root of the breadcrumbs.
unknown_2023.01.12-19.03.mp4
For a new project where only the
Standard
namespace exists the only visible change is the breadcrumbs. Adding for example additional modules in the projectsrc
folder will create them in thelocal
namespace, this namespace will show up as a separate navigator section.Important Notes
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide build
and./run ide watch
.