Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5123 Text.tokenize #6150

Merged
merged 9 commits into from
Apr 3, 2023
Merged

#5123 Text.tokenize #6150

merged 9 commits into from
Apr 3, 2023

Conversation

GregoryTravis
Copy link
Contributor

Pull Request Description

Implement Text.tokenize.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@GregoryTravis GregoryTravis marked this pull request as ready for review March 30, 2023 15:04
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can we test for one where a sub-group is conditional - something like ((ab)|(baa)).

Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@GregoryTravis GregoryTravis added the CI: Ready to merge This PR is eligible for automatic merge label Apr 3, 2023
@mergify mergify bot merged commit 6766389 into develop Apr 3, 2023
@mergify mergify bot deleted the wip/gmt/5123-text-tokenize branch April 3, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants