Implement create_database_table for Database Table
#6467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
approved these changes
Apr 28, 2023
| to_select_query : Query | ||
| to_select_query self = | ||
| cols = self.internal_columns.map (c -> [c.name, c.expression]) | ||
| # assert cols.not_empty |
There was a problem hiding this comment.
Is this interpreted by the compiler or just a regular comment?
There was a problem hiding this comment.
Regular comment.
We have plans to support Enso assertions #5973 so I thought it's worth to mark these so that we can then grep and replace them with proper thing, once available.
There was a problem hiding this comment.
That's a great idea, I'll start doing that too.
radeusgd
force-pushed
the
wip/radeusgd/6327-create-database-table-from-query
branch
from
e9467af
to
d0181ad
Compare
radeusgd
changed the base branch from
develop
to
wip/radeusgd/6398-fix-postgres-temporary-table-listing
radeusgd
force-pushed
the
wip/radeusgd/6398-fix-postgres-temporary-table-listing
branch
from
dad7666
to
2fb729f
Compare
radeusgd
force-pushed
the
wip/radeusgd/6327-create-database-table-from-query
branch
from
d0181ad
to
166fb09
Compare
Base automatically changed from
wip/radeusgd/6398-fix-postgres-temporary-table-listing
to
develop
April 29, 2023 00:13
radeusgd
force-pushed
the
wip/radeusgd/6327-create-database-table-from-query
branch
2 times, most recently
from
ec0e008
to
a07220a
Compare
jdunkerley
approved these changes
May 2, 2023
distribution/lib/Standard/Database/0.0.0-dev/src/Internal/IR/Query.enso
Outdated
Show resolved
Hide resolved
… of uniqueness check
…uery.enso Co-authored-by: James Dunkerley <jdunkerley@users.noreply.github.com>
radeusgd
force-pushed
the
wip/radeusgd/6327-create-database-table-from-query
branch
from
58a3514
to
b30e569
Compare
Procrat
added a commit
that referenced
this pull request
May 3, 2023
* develop: (34 commits) Continued Execution Context work and some little fixes (#6506) IDE's logging to a file (#6478) Fix application config (#6513) Cloud/desktop mode switcher (#6448) Fix doubled named arguments bug (#6422) Reimplement `enso_project` as a proper builtin (#6352) Fix layer ordering between dropdown and breadcrumbs backgrounds. (#6483) Multiflavor layers (#6477) DataflowAnalysis preserves dependencies order (#6493) Implement `create_database_table` for Database Table (#6467) Limit Dead Letter logging (#6482) More reliable shutdown of the EnsoContext to save resources (#6468) Make execution mode `live` default for CLI (#6496) Finishing Vector Editor (#6470) Proper handling of multiple list views. (#6461) Fix disappearing cached shapes (#6458) Add Execution Context control to Text.write (#6459) Change defaults for `Connection.tables` and ensure that `Connection.query` recognizes all available tables (#6443) Introducing @BuiltinMethod.needsFrame and InlineableNode (#6442) Hide profile button behind a feature flag (#6430) ...
Procrat
added a commit
that referenced
this pull request
May 4, 2023
* develop: Fix cut-off in text visualisations (#6421) Infer correct synthetic name for nested modules (#6525) Delete unused websocket dependency (#6535) Run typecheck and eslint on `./run lint` (#6314) Force pending saves if client closes abruptly (#6514) Continued Execution Context work and some little fixes (#6506) IDE's logging to a file (#6478) Fix application config (#6513) Cloud/desktop mode switcher (#6448) Fix doubled named arguments bug (#6422) Reimplement `enso_project` as a proper builtin (#6352) Fix layer ordering between dropdown and breadcrumbs backgrounds. (#6483) Multiflavor layers (#6477) DataflowAnalysis preserves dependencies order (#6493) Implement `create_database_table` for Database Table (#6467) Limit Dead Letter logging (#6482) More reliable shutdown of the EnsoContext to save resources (#6468) Make execution mode `live` default for CLI (#6496)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #6327
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.